[L] Change in dart/sdk[main]: [vm] Remove CallLeafRuntimeStubCode test.
0 views
Skip to first unread message
Ryan Macnak (Gerrit)
Feb 12, 2026, 10:41:57 PM (5 days ago) Feb 12
to Tess Strickland, Commit Queue, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Tess Strickland
Ryan Macnak added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Ryan Macnak . resolved
Removing the leaf runtime entry the test uses, and if runtime entries are broken the build won't even be able to produce the test binary anyway.
Related details
Attention is currently required from:
- Tess Strickland
Submit Requirements:
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tess Strickland (Gerrit)
Feb 13, 2026, 8:22:05 AM (5 days ago) Feb 13
to Ryan Macnak, Commit Queue, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Ryan Macnak
Tess Strickland voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Ryan Macnak
Submit Requirements:
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ryan Macnak (Gerrit)
12:52 PM (8 hours ago) 12:52 PM
to Tess Strickland, Commit Queue, rev...@dartlang.org, vm-...@dartlang.org
Ryan Macnak voted Commit-Queue+2![]( "Open in Gerrit")
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Commit Queue (Gerrit)
1:31 PM (7 hours ago) 1:31 PM
to Ryan Macnak, Tess Strickland, rev...@dartlang.org, vm-...@dartlang.org
Commit Queue submitted the change![]( "Open in Gerrit")
Unreviewed changes
1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
[vm] Remove CallLeafRuntimeStubCode test.
TEST=ci
Change-Id: I7371e65b31d482c519ee240660307735946d5f0f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/480401
Reviewed-by: Tess Strickland <sstr...@google.com>
Commit-Queue: Ryan Macnak <rma...@google.com>
Files:
- D runtime/vm/stub_code_arm64_test.cc
- D runtime/vm/stub_code_arm_test.cc
- D runtime/vm/stub_code_ia32_test.cc
- D runtime/vm/stub_code_riscv_test.cc
- D runtime/vm/stub_code_test.cc
- D runtime/vm/stub_code_x64_test.cc
- M runtime/vm/vm_sources.gni
Change size: L
Delta: 7 files changed, 0 insertions(+), 673 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Tess Strickland
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages