[XS] Change in dart/sdk[main]: [vm/shared/interpreter] Use shared-aware initializer from interpreter.

0 views

Skip to first unread message

Ryan Macnak (Gerrit)

unread,

7:30 PM (4 hours ago) 7:30 PM

to Alexander Aprelev, dart-...@luci-project-accounts.iam.gserviceaccount.com, rev...@dartlang.org, vm-...@dartlang.org

Attention needed from Alexander Aprelev

Ryan Macnak voted Code-Review+1

Code-Review

Open in Gerrit

Related details

Attention is currently required from:

Alexander Aprelev

Submit Requirements:

Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Alexander Aprelev (Gerrit)

unread,

7:30 PM (4 hours ago) 7:30 PM

to Alexander Aprelev, Ryan Macnak, dart-...@luci-project-accounts.iam.gserviceaccount.com, rev...@dartlang.org, vm-...@dartlang.org

Alexander Aprelev voted and added 1 comment

Votes added by Alexander Aprelev

Commit-Queue

1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Alexander Aprelev . resolved

thanks!

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)

unread,

7:36 PM (4 hours ago) 7:36 PM

to Alexander Aprelev, Ryan Macnak, rev...@dartlang.org, vm-...@dartlang.org

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change

Change information

Commit message:

[vm/shared/interpreter] Use shared-aware initializer from interpreter.

BUG=https://github.com/dart-lang/sdk/issues/63801
TEST=ci

Change-Id: I1d2d87b838ed1c52ff93f5ac5f28ee9105bf0728

Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/524647

Reviewed-by: Ryan Macnak <rma...@google.com>

Commit-Queue: Alexander Aprelev <a...@google.com>

Files:

M runtime/vm/interpreter.cc

Change size: XS

Delta: 1 file changed, 1 insertion(+), 1 deletion(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Ryan Macnak

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages