[S] Change in dart/sdk[main]: DAS: Test that unused parameters can be removed from primary construc...
0 views
Skip to first unread message
Brian Wilkerson (Gerrit)
1:08 PM (7 hours ago) 1:08 PM
to Samuel Rawlins, Brian Wilkerson, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Samuel Rawlins
Brian Wilkerson voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Samuel Rawlins
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Samuel Rawlins (Gerrit)
1:09 PM (7 hours ago) 1:09 PM
to Brian Wilkerson, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Samuel Rawlins voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Commit Queue (Gerrit)
1:09 PM (7 hours ago) 1:09 PM
to Samuel Rawlins, Brian Wilkerson, dart-analys...@google.com, rev...@dartlang.org
Commit Queue submitted the change![]( "Open in Gerrit")
Change information
Commit message:
DAS: Test that unused parameters can be removed from primary constructors
Work towards https://github.com/dart-lang/sdk/issues/62274
I wanted to add a test to show that a declaring parameter _wouldn't_
be removed, but of course, the test infra is set up that it at least
expects a diagnostic in the code. So that test belongs in the
diagnostics tests, like maybe unused_element_test. Ah well.
Change-Id: I638bf024e93eab0f22c6d590349b7aa4af194e02
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/481022
Commit-Queue: Samuel Rawlins <sraw...@google.com>
Reviewed-by: Brian Wilkerson <brianwi...@google.com>
Files:
- M pkg/analysis_server/test/src/services/correction/fix/remove_unused_parameter_test.dart
Change size: S
Delta: 1 file changed, 27 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Brian Wilkerson
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages