[M] Change in dart/sdk[main]: [vm, compiler] Add --target-address-sanitizer.
0 views
Skip to first unread message
Ryan Macnak (Gerrit)
Dec 1, 2025, 2:18:07 PM (21 hours ago) Dec 1
to Alexander Aprelev, Commit Queue, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Alexander Aprelev
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Alexander Aprelev
Submit Requirements:
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alexander Aprelev (Gerrit)
Dec 1, 2025, 2:23:44 PM (21 hours ago) Dec 1
to Ryan Macnak, Alexander Aprelev, Commit Queue, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Ryan Macnak
Alexander Aprelev voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Ryan Macnak
Submit Requirements:
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ryan Macnak (Gerrit)
Dec 1, 2025, 6:36:19 PM (17 hours ago) Dec 1
to Alexander Aprelev, Commit Queue, rev...@dartlang.org, vm-...@dartlang.org
Ryan Macnak voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Commit Queue (Gerrit)
Dec 1, 2025, 7:15:44 PM (16 hours ago) Dec 1
to Ryan Macnak, Alexander Aprelev, rev...@dartlang.org, vm-...@dartlang.org
Commit Queue submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
5 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: runtime/BUILD.gn
Insertions: 1, Deletions: 1.
@@ -112,7 +112,7 @@
# In our GN build rules we'll always compile AOT compiler & AOT runtime in
# the same mode (TSAN or non-TSAN).
- if (is_asan) {
+ if (is_asan && !is_win) {
defines += [ "TARGET_USES_ADDRESS_SANITIZER" ]
} else if (is_msan) {
defines += [ "TARGET_USES_MEMORY_SANITIZER" ]
```
Change information
Commit message:
[vm, compiler] Add --target-address-sanitizer.
The throw stub will need to be different under ASAN.
TEST=ci
Bug: https://github.com/dart-lang/sdk/issues/62095
Change-Id: Idd079fbab22d1c3f29c0d7e216998d54a521545c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/464786
Reviewed-by: Alexander Aprelev <a...@google.com>
Commit-Queue: Ryan Macnak <rma...@google.com>
Files:
- M runtime/BUILD.gn
- M runtime/tests/vm/dart/sanitizer_compatibility_test.dart
- M runtime/vm/dart.cc
- M runtime/vm/flag_list.h
- M runtime/vm/flags.cc
- M runtime/vm/flags.h
Change size: M
Delta: 6 files changed, 35 insertions(+), 16 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Alexander Aprelev
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages