[M] Change in dart/sdk[main]: [dart2wasm] Fix access of constants under deferred load guard
0 views
Skip to first unread message
Ömer Ağacan (Gerrit)
Nov 28, 2025, 6:21:02 AM (yesterday) Nov 28
to Martin Kustermann, Commit Queue, dart2js-te...@google.com, dart2wasm-t...@google.com, rev...@dartlang.org
Attention needed from Martin Kustermann
Ömer Ağacan voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Martin Kustermann
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Martin Kustermann (Gerrit)
Nov 28, 2025, 6:22:48 AM (yesterday) Nov 28
to Ömer Ağacan, Commit Queue, dart2js-te...@google.com, dart2wasm-t...@google.com, rev...@dartlang.org
Martin Kustermann voted and added 1 comment![]( "Open in Gerrit")
Votes added by Martin Kustermann
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Commit Queue (Gerrit)
Nov 28, 2025, 6:23:06 AM (yesterday) Nov 28
to Martin Kustermann, Ömer Ağacan, dart2js-te...@google.com, dart2wasm-t...@google.com, rev...@dartlang.org
Commit Queue submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[dart2wasm] Fix access of constants under deferred load guard
When accessing a constant under a load guard we can push the constant to
the deferred module (as we only access it under the guard that the
module has been loaded). The access has to therefore also use the
constant initializer function from the deferred module.
We also remove `--extra-compiler-option` prefix for
`--enable-deferred-loading` as the prefix isn't recognized by
dartdev.
Change-Id: I58489303dc10bb265ef730c05a4fc78a8f598edb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/464980
Reviewed-by: Ömer Ağacan <ome...@google.com>
Commit-Queue: Martin Kustermann <kuste...@google.com>
Files:
- M pkg/dart2wasm/lib/constants.dart
- M pkg/dart2wasm/tool/compile_benchmark
- M tests/language/deferred/regression_22995_test.dart
- A tests/web/wasm/deferred_constant_use_under_load_guard_def.dart
- A tests/web/wasm/deferred_constant_use_under_load_guard_def1.dart
- A tests/web/wasm/deferred_constant_use_under_load_guard_def2.dart
- A tests/web/wasm/deferred_constant_use_under_load_guard_test.dart
- M tests/web/wasm/source_map_simple_optimized_deferred_test.dart
Change size: M
Delta: 8 files changed, 77 insertions(+), 10 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Ömer Ağacan
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages