[M] Change in dart/sdk[main]: [DAS] Fixes import with prefix to work with annotations

0 views
Skip to first unread message

Felipe Morschel (Gerrit)

unread,
Dec 17, 2025, 2:33:04 PM (4 days ago) Dec 17
to dart-analys...@google.com, rev...@dartlang.org

Felipe Morschel has uploaded the change for review

Commit message

[DAS] Fixes import with prefix to work with annotations
Change-Id: I0dc38fbf16a3f88a4380c94d856c89fc5d8130df

Change information

Files:
  • M pkg/analysis_server/lib/src/services/correction/dart/import_library.dart
  • M pkg/analysis_server/test/src/services/correction/fix/import_library_prefix_test.dart
  • M pkg/analysis_server/test/src/services/correction/fix/import_library_project_test.dart
Change size: M
Delta: 3 files changed, 131 insertions(+), 31 deletions(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I0dc38fbf16a3f88a4380c94d856c89fc5d8130df
Gerrit-Change-Number: 468903
Gerrit-PatchSet: 1
Gerrit-Owner: Felipe Morschel <g...@fmorschel.dev>
Gerrit-Reviewer: Felipe Morschel <g...@fmorschel.dev>
unsatisfied_requirement
open
diffy

Samuel Rawlins (Gerrit)

unread,
Dec 17, 2025, 7:58:35 PM (4 days ago) Dec 17
to Felipe Morschel, Brian Wilkerson, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Brian Wilkerson and Felipe Morschel

Samuel Rawlins voted and added 1 comment

Votes added by Samuel Rawlins

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Samuel Rawlins . resolved

Excellent, thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Brian Wilkerson
  • Felipe Morschel
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I0dc38fbf16a3f88a4380c94d856c89fc5d8130df
Gerrit-Change-Number: 468903
Gerrit-PatchSet: 1
Gerrit-Owner: Felipe Morschel <g...@fmorschel.dev>
Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
Gerrit-Reviewer: Felipe Morschel <g...@fmorschel.dev>
Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
Gerrit-Attention: Brian Wilkerson <brianwi...@google.com>
Gerrit-Attention: Felipe Morschel <g...@fmorschel.dev>
Gerrit-Comment-Date: Thu, 18 Dec 2025 00:58:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Brian Wilkerson (Gerrit)

unread,
Dec 19, 2025, 4:02:16 PM (2 days ago) Dec 19
to Felipe Morschel, Brian Wilkerson, Commit Queue, Samuel Rawlins, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Felipe Morschel

Brian Wilkerson voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Felipe Morschel
Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: I0dc38fbf16a3f88a4380c94d856c89fc5d8130df
    Gerrit-Change-Number: 468903
    Gerrit-PatchSet: 1
    Gerrit-Owner: Felipe Morschel <g...@fmorschel.dev>
    Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
    Gerrit-Reviewer: Felipe Morschel <g...@fmorschel.dev>
    Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
    Gerrit-Attention: Felipe Morschel <g...@fmorschel.dev>
    Gerrit-Comment-Date: Fri, 19 Dec 2025 21:02:13 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Commit Queue (Gerrit)

    unread,
    Dec 19, 2025, 4:29:21 PM (2 days ago) Dec 19
    to Felipe Morschel, Brian Wilkerson, Samuel Rawlins, dart-analys...@google.com, rev...@dartlang.org

    Commit Queue submitted the change

    Change information

    Commit message:
    [DAS] Fixes import with prefix to work with annotations
    Change-Id: I0dc38fbf16a3f88a4380c94d856c89fc5d8130df
    Reviewed-by: Brian Wilkerson <brianwi...@google.com>
    Auto-Submit: Felipe Morschel <g...@fmorschel.dev>
    Reviewed-by: Samuel Rawlins <sraw...@google.com>
    Commit-Queue: Brian Wilkerson <brianwi...@google.com>
    Files:
    • M pkg/analysis_server/lib/src/services/correction/dart/import_library.dart
    • M pkg/analysis_server/test/src/services/correction/fix/import_library_prefix_test.dart
    • M pkg/analysis_server/test/src/services/correction/fix/import_library_project_test.dart
    Change size: M
    Delta: 3 files changed, 131 insertions(+), 31 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Brian Wilkerson, +1 by Samuel Rawlins
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: I0dc38fbf16a3f88a4380c94d856c89fc5d8130df
    Gerrit-Change-Number: 468903
    Gerrit-PatchSet: 2
    Gerrit-Owner: Felipe Morschel <g...@fmorschel.dev>
    Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages