[L] Change in dart/sdk[main]: [analyzer] Adds new diagnostic for `unsupported_lint`
Felipe Morschel (Gerrit)
Felipe Morschel has uploaded the change for review![]( "Open in Gerrit")
Commit message
[analyzer] Adds new diagnostic for `unsupported_lint`
This is a step towards better handling lints for specific features. In a future CL we will review all lints and add the feature tag where appropriate.
Change information
- M pkg/analysis_server/lib/src/context_manager.dart
- M pkg/analysis_server/lib/src/handler/legacy/edit_get_fixes.dart
- M pkg/analysis_server/lib/src/lsp/handlers/code_actions/analysis_options.dart
- M pkg/analysis_server/test/services/linter/linter_test.dart
- M pkg/analysis_server/test/src/services/correction/fix/analysis_options/test_support.dart
- M pkg/analyzer/lib/analysis_rule/rule_state.dart
- M pkg/analyzer/lib/src/analysis_options/error/option_codes.g.dart
- M pkg/analyzer/lib/src/analysis_options/options_file_validator.dart
- M pkg/analyzer/lib/src/diagnostic/diagnostic_code_values.g.dart
- M pkg/analyzer/lib/src/lint/options_rule_validator.dart
- M pkg/analyzer/messages.yaml
- M pkg/analyzer/test/src/diagnostics/analysis_options/analysis_options_test_support.dart
- M pkg/analyzer/test/src/options/options_file_validator_test.dart
- M pkg/analyzer/test/src/options/options_rule_validator_test.dart
- M pkg/analyzer_cli/lib/src/driver.dart
- M pkg/linter/tool/messages_info.dart
Related details
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Felipe Morschel (Gerrit)
Felipe Morschel added 1 comment![]( "Open in Gerrit")
Adding @paul...@google.com as CC mostly because of the changes to `messages.yaml`.
Related details
- Brian Wilkerson
- Konstantin Shcheglov
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Paul Berry (Gerrit)
Paul Berry added 3 comments![]( "Open in Gerrit")
Added some drive-by comments to `pkg/analyzer/messages.yaml`. Let me know if you want me to do a full review.
String p0: the rule nameThe reason all the existing messages have parameters called `p0`, `p1`, etc. is because when I added the ability to give parameters names, I didn't want to stall my progress by thinking carefully about good names for all of the existing parameters. I intend to go back and assign better names for parameters over time.
For new messages, we should go ahead and give them good parameter names from the outset. Consider something like:
```
parameters:
String ruleName: the rule name
String featureName: the feature name
problemMessage: "'#ruleName' can't be active because it requires the '#featureName' experiment."
...
```
Related details
- Brian Wilkerson
- Felipe Morschel
- Konstantin Shcheglov
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Felipe Morschel (Gerrit)
Felipe Morschel added 1 comment![]( "Open in Gerrit")
String p0: the rule nameThe reason all the existing messages have parameters called `p0`, `p1`, etc. is because when I added the ability to give parameters names, I didn't want to stall my progress by thinking carefully about good names for all of the existing parameters. I intend to go back and assign better names for parameters over time.
For new messages, we should go ahead and give them good parameter names from the outset. Consider something like:
```
parameters:
String ruleName: the rule name
String featureName: the feature name
problemMessage: "'#ruleName' can't be active because it requires the '#featureName' experiment."
...
```
Ohh! That makes so much more sense! I should've realized it sooner!
At least this and https://dart-review.googlesource.com/c/sdk/+/448601 will have that but I'll have to send a new CL for https://dart-review.googlesource.com/c/sdk/+/429240 hahaha.
Thanks! I'll update this later.
Related details
- Brian Wilkerson
- Konstantin Shcheglov
- Paul Berry
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Felipe Morschel (Gerrit)
Felipe Morschel added 1 comment![]( "Open in Gerrit")
var requiredFeature = _readFeature(data);@paul...@google.com not a full review but the CC was mostly because of these changes (around this file). Just to make sure you have seen them.
Paul Berry (Gerrit)
Paul Berry added 3 comments![]( "Open in Gerrit")
String p0: the rule nameFelipe MorschelThe reason all the existing messages have parameters called `p0`, `p1`, etc. is because when I added the ability to give parameters names, I didn't want to stall my progress by thinking carefully about good names for all of the existing parameters. I intend to go back and assign better names for parameters over time.
For new messages, we should go ahead and give them good parameter names from the outset. Consider something like:
```
parameters:
String ruleName: the rule name
String featureName: the feature name
problemMessage: "'#ruleName' can't be active because it requires the '#featureName' experiment."
...
```
Ohh! That makes so much more sense! I should've realized it sooner!
At least this and https://dart-review.googlesource.com/c/sdk/+/448601 will have that but I'll have to send a new CL for https://dart-review.googlesource.com/c/sdk/+/429240 hahaha.
Thanks! I'll update this later.
Acknowledged
String p0: the rule namePaul BerrySimilar issue here
Marking this as "resolved" because I'm fine with it happening either in this CL or a future CL; your choice.
var requiredFeature = _readFeature(data);@paul...@google.com not a full review but the CC was mostly because of these changes (around this file). Just to make sure you have seen them.
- Brian Wilkerson
- Felipe Morschel
- Konstantin Shcheglov
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Brian Wilkerson (Gerrit)
Brian Wilkerson added 4 comments![]( "Open in Gerrit")
I added a couple of minor comments as I was trying to get the context to review this CL, but you should ignore them in favor of addressing the bigger issue, for which I added notes to the issue.
problemMessage: "'#p0' can't be active because it requires the '#p1' experiment.""active" --> "enabled"
problemMessage: "'#p0' can't be active because it requires the '#p1' experiment.""experiment" --> "experiment to be enabled"
correctionMessage: "Try using Dart '#p2' or later or enabling the '#p1' experiment."This seems like the wrong fix for what I think this diagnostic is for. I don't know whether the message is bad or whether my understanding is off.
I'm guessing that `unsupported_lint` is generated when a lint rule requires that a given experiment be enabled and it isn't. I'd then guess that `unsupported_lint_version` is generated when a lint rule requires a certain version or above and the minimum SDK constraints are below that version.
If that's true, then the fix is to change the minimum sdk constraint, not to enable an experiment.
Related details
- Felipe Morschel
- Konstantin Shcheglov
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |