[L] Change in dart/sdk[main]: Parse and validate analyzer plugins in "inner" options files

0 views
Skip to first unread message

Brian Wilkerson (Gerrit)

unread,
Jul 15, 2026, 5:42:47 PM (10 hours ago) Jul 15
to Samuel Rawlins, Brian Wilkerson, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Samuel Rawlins

Brian Wilkerson voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Samuel Rawlins
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I4180018cb536e0d996e50395dc2611e65d799bac
Gerrit-Change-Number: 524521
Gerrit-PatchSet: 5
Gerrit-Owner: Samuel Rawlins <sraw...@google.com>
Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
Gerrit-Attention: Samuel Rawlins <sraw...@google.com>
Gerrit-Comment-Date: Wed, 15 Jul 2026 21:42:42 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Samuel Rawlins (Gerrit)

unread,
Jul 15, 2026, 6:16:49 PM (10 hours ago) Jul 15
to Brian Wilkerson, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-analys...@google.com, rev...@dartlang.org

Samuel Rawlins voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I4180018cb536e0d996e50395dc2611e65d799bac
Gerrit-Change-Number: 524521
Gerrit-PatchSet: 5
Gerrit-Owner: Samuel Rawlins <sraw...@google.com>
Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
Gerrit-Comment-Date: Wed, 15 Jul 2026 22:16:46 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)

unread,
Jul 15, 2026, 6:17:00 PM (10 hours ago) Jul 15
to Samuel Rawlins, Brian Wilkerson, dart-analys...@google.com, rev...@dartlang.org

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change

Change information

Commit message:
Parse and validate analyzer plugins in "inner" options files

Work towards https://github.com/dart-lang/sdk/issues/63627

We don't yet act on the inner options files. That is next. But there
is enough code and testing just in validating that they don't conflict,
so this CL is first.
Change-Id: I4180018cb536e0d996e50395dc2611e65d799bac
Reviewed-by: Brian Wilkerson <brianwi...@google.com>
Commit-Queue: Samuel Rawlins <sraw...@google.com>
Files:
  • M pkg/analysis_server/lib/src/context_manager.dart
  • M pkg/analysis_server/lib/src/services/correction/error_fix_status.yaml
  • M pkg/analysis_server/pubspec.yaml
  • M pkg/analysis_server/test/analysis/notification_analysis_options_test.dart
  • M pkg/analysis_server/test/domain_analysis_test.dart
  • M pkg/analyzer/lib/src/diagnostic/diagnostic.g.dart
  • M pkg/analyzer/lib/src/diagnostic/diagnostic_code_values.g.dart
  • M pkg/analyzer/messages.yaml
Change size: L
Delta: 8 files changed, 423 insertions(+), 41 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Brian Wilkerson
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I4180018cb536e0d996e50395dc2611e65d799bac
Gerrit-Change-Number: 524521
Gerrit-PatchSet: 6
Gerrit-Owner: Samuel Rawlins <sraw...@google.com>
Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages