[M] Change in dart/sdk[main]: linter: Refactor ASCII utils file
0 views
Skip to first unread message
Samuel Rawlins (Gerrit)
Jan 9, 2026, 10:48:46 AM (2 days ago) Jan 9
to Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Samuel Rawlins abandoned this change![]( "Open in Gerrit")
Related details
Attention set is empty
Submit Requirements:
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Brian Wilkerson (Gerrit)
Jan 9, 2026, 2:40:46 PM (2 days ago) Jan 9
to Samuel Rawlins, Brian Wilkerson, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Samuel Rawlins
Brian Wilkerson voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Samuel Rawlins
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Samuel Rawlins (Gerrit)
Jan 9, 2026, 2:45:47 PM (2 days ago) Jan 9
to Brian Wilkerson, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Samuel Rawlins voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Commit Queue (Gerrit)
Jan 9, 2026, 2:46:04 PM (2 days ago) Jan 9
to Samuel Rawlins, Brian Wilkerson, dart-analys...@google.com, rev...@dartlang.org
Commit Queue submitted the change![]( "Open in Gerrit")
Change information
Commit message:
linter: Refactor ASCII utils file
Some of these are unused in linter, so can be made private. Some of them
are so simple (`=> character == $dot`) that they can just be inlined,
I believe without losing any readability.
Change-Id: Ic6142fab3bc548e831190d5701bed1bbd3f1f739
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/471862
Reviewed-by: Brian Wilkerson <brianwi...@google.com>
Commit-Queue: Samuel Rawlins <sraw...@google.com>
Files:
- M pkg/linter/lib/src/util/ascii_utils.dart
Change size: S
Delta: 1 file changed, 10 insertions(+), 16 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Brian Wilkerson
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages