[M] Change in dart/sdk[main]: [cfe][PrivateNamedParameters] Share code for checking public name
1 view
Skip to first unread message
Johnni Winther (Gerrit)
Jan 8, 2026, 9:31:05 AM (3 days ago) Jan 8
to Konstantin Shcheglov, Commit Queue, dart-fe-te...@google.com, rev...@dartlang.org
Attention needed from Johnni Winther and Konstantin Shcheglov
Johnni Winther voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Johnni Winther
- Konstantin Shcheglov
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Konstantin Shcheglov (Gerrit)
Jan 8, 2026, 4:58:41 PM (2 days ago) Jan 8
to Johnni Winther, Commit Queue, dart-fe-te...@google.com, rev...@dartlang.org
Attention needed from Johnni Winther
Konstantin Shcheglov voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Johnni Winther
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Johnni Winther (Gerrit)
Jan 9, 2026, 9:07:11 AM (2 days ago) Jan 9
to Konstantin Shcheglov, Commit Queue, dart-fe-te...@google.com, rev...@dartlang.org
Johnni Winther voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Commit Queue (Gerrit)
Jan 9, 2026, 9:54:34 AM (2 days ago) Jan 9
to Johnni Winther, Konstantin Shcheglov, dart-fe-te...@google.com, rev...@dartlang.org
Commit Queue submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[cfe][PrivateNamedParameters] Share code for checking public name
This share the code for checking and computing the public name for a private named parameter.
Change-Id: Ief1797ebe749b8101016e002c7687d1f553ec2dd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/471481
Commit-Queue: Johnni Winther <johnni...@google.com>
Reviewed-by: Konstantin Shcheglov <sche...@google.com>
Files:
- M pkg/front_end/lib/src/kernel/body_builder.dart
- M pkg/front_end/lib/src/source/check_helper.dart
- M pkg/front_end/lib/src/source/outline_builder.dart
- M pkg/front_end/lib/src/source/source_compilation_unit.dart
Change size: M
Delta: 4 files changed, 103 insertions(+), 100 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Konstantin Shcheglov
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages