[L] Change in dart/sdk[main]: Remove `var` and `final` from parameters in `pkg/`.

0 views
Skip to first unread message

Lasse Nielsen (Gerrit)

unread,
Feb 13, 2026, 1:07:49 PM (3 days ago) Feb 13
to Nate Bosch, Ryan Macnak, Johnni Winther, Mayank Patke, Commit Queue, Alexander Markov, Jens Johansen, dart-fe-te...@google.com, dart2js-te...@google.com, rev...@dartlang.org
Attention needed from Johnni Winther, Mayank Patke, Nate Bosch and Ryan Macnak

Lasse Nielsen added 1 comment

Patchset-level comments
File-level comment, Patchset 5 (Latest):
Lasse Nielsen . resolved

Lots of different owners.

Open in Gerrit

Related details

Attention is currently required from:
  • Johnni Winther
  • Mayank Patke
  • Nate Bosch
  • Ryan Macnak
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedCommit-Message-Has-TEST
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I7f5aa4cc98001a9adecacd106c0b3be14f96be1c
Gerrit-Change-Number: 480542
Gerrit-PatchSet: 5
Gerrit-Owner: Lasse Nielsen <l...@google.com>
Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
Gerrit-Reviewer: Lasse Nielsen <l...@google.com>
Gerrit-Reviewer: Mayank Patke <fishyt...@google.com>
Gerrit-Reviewer: Nate Bosch <nbo...@google.com>
Gerrit-Reviewer: Ryan Macnak <rma...@google.com>
Gerrit-CC: Alexander Markov <alexm...@google.com>
Gerrit-CC: Jens Johansen <je...@google.com>
Gerrit-Attention: Nate Bosch <nbo...@google.com>
Gerrit-Attention: Mayank Patke <fishyt...@google.com>
Gerrit-Attention: Ryan Macnak <rma...@google.com>
Gerrit-Attention: Johnni Winther <johnni...@google.com>
Gerrit-Comment-Date: Fri, 13 Feb 2026 18:07:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Nate Bosch (Gerrit)

unread,
Feb 13, 2026, 1:09:26 PM (3 days ago) Feb 13
to Lasse Nielsen, Ryan Macnak, Johnni Winther, Mayank Patke, Commit Queue, Alexander Markov, Jens Johansen, dart-fe-te...@google.com, dart2js-te...@google.com, rev...@dartlang.org
Attention needed from Johnni Winther, Lasse Nielsen, Mayank Patke and Ryan Macnak

Nate Bosch voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Johnni Winther
  • Lasse Nielsen
  • Mayank Patke
  • Ryan Macnak
Submit Requirements:
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedCommit-Message-Has-TEST
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: I7f5aa4cc98001a9adecacd106c0b3be14f96be1c
    Gerrit-Change-Number: 480542
    Gerrit-PatchSet: 5
    Gerrit-Owner: Lasse Nielsen <l...@google.com>
    Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
    Gerrit-Reviewer: Lasse Nielsen <l...@google.com>
    Gerrit-Reviewer: Mayank Patke <fishyt...@google.com>
    Gerrit-Reviewer: Nate Bosch <nbo...@google.com>
    Gerrit-Reviewer: Ryan Macnak <rma...@google.com>
    Gerrit-CC: Alexander Markov <alexm...@google.com>
    Gerrit-CC: Jens Johansen <je...@google.com>
    Gerrit-Attention: Mayank Patke <fishyt...@google.com>
    Gerrit-Attention: Ryan Macnak <rma...@google.com>
    Gerrit-Attention: Johnni Winther <johnni...@google.com>
    Gerrit-Attention: Lasse Nielsen <l...@google.com>
    Gerrit-Comment-Date: Fri, 13 Feb 2026 18:09:22 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    unsatisfied_requirement
    satisfied_requirement
    open
    diffy

    Johnni Winther (Gerrit)

    unread,
    4:14 AM (12 hours ago) 4:14 AM
    to Lasse Nielsen, Nate Bosch, Ryan Macnak, Mayank Patke, Commit Queue, Alexander Markov, Jens Johansen, dart-fe-te...@google.com, dart2js-te...@google.com, rev...@dartlang.org
    Attention needed from Lasse Nielsen, Mayank Patke and Ryan Macnak

    Johnni Winther voted and added 3 comments

    Votes added by Johnni Winther

    Code-Review+1

    3 comments

    File pkg/front_end/test/parser_test_parser.dart
    Line 1, Patchset 5 (Latest):// Copyright (c) 2019, the Dart project authors. Please see the AUTHORS file
    Johnni Winther . unresolved

    This file is generated so you need to update the generator `pkg/front_end/test/parser_test_parser_creator.dart` instead.

    File pkg/front_end/testcases/extension_types/representation_field_error_2.dart.strong.expect
    Line 5, Patchset 5 (Parent):// pkg/front_end/testcases/extension_types/representation_field_error_2.dart:5:23: Error: Representation fields can't have modifiers.
    Johnni Winther . unresolved

    I guess you've changed the file `representation_field_error_2.dart` but revert the change but not the expectation.

    `representation_field_error_2.dart` and its `.expect` files here and below shouldn't be updated; it is meant to test for reported errors.

    File pkg/front_end/testcases/nnbd/required_2.dart
    Line 1, Patchset 5 (Parent):// Copyright (c) 2026, the Dart project authors. Please see the AUTHORS file
    Johnni Winther . unresolved

    This file shouldn't be updated; it is meant to test for reported errors.

    Open in Gerrit

    Related details

    Attention is currently required from:
    Gerrit-Attention: Lasse Nielsen <l...@google.com>
    Gerrit-Comment-Date: Mon, 16 Feb 2026 09:14:25 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    unsatisfied_requirement
    satisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages