[M] Change in dart/sdk[main]: [modular_aot] Code generation for binary int operations add/sub/mul/o...

0 views
Skip to first unread message

Alexander Markov (Gerrit)

unread,
Mar 6, 2026, 4:14:58 PM (4 days ago) Mar 6
to Alexander Markov, Slava Egorov, Nate Biggs, Nicholas Shahan, Stephen Adams, Tess Strickland, Alexander Aprelev, Commit Queue, rev...@dartlang.org
Attention needed from Slava Egorov

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Slava Egorov
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Ic922522f77624ede28b05ab6c9e67f33c82859c9
Gerrit-Change-Number: 486281
Gerrit-PatchSet: 1
Gerrit-Owner: Alexander Markov <alexm...@google.com>
Gerrit-Reviewer: Alexander Markov <alexm...@google.com>
Gerrit-Reviewer: Slava Egorov <veg...@google.com>
Gerrit-CC: Alexander Aprelev <a...@google.com>
Gerrit-CC: Nate Biggs <nate...@google.com>
Gerrit-CC: Nicholas Shahan <nsh...@google.com>
Gerrit-CC: Stephen Adams <s...@google.com>
Gerrit-CC: Tess Strickland <sstr...@google.com>
Gerrit-Attention: Slava Egorov <veg...@google.com>
Gerrit-Comment-Date: Fri, 06 Mar 2026 21:14:54 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Slava Egorov (Gerrit)

unread,
Mar 9, 2026, 3:23:52 PM (15 hours ago) Mar 9
to Alexander Markov, Nate Biggs, Nicholas Shahan, Stephen Adams, Tess Strickland, Alexander Aprelev, Commit Queue, rev...@dartlang.org
Attention needed from Alexander Markov

Slava Egorov voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Alexander Markov
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Ic922522f77624ede28b05ab6c9e67f33c82859c9
Gerrit-Change-Number: 486281
Gerrit-PatchSet: 2
Gerrit-Owner: Alexander Markov <alexm...@google.com>
Gerrit-Reviewer: Alexander Markov <alexm...@google.com>
Gerrit-Reviewer: Slava Egorov <veg...@google.com>
Gerrit-CC: Alexander Aprelev <a...@google.com>
Gerrit-CC: Nate Biggs <nate...@google.com>
Gerrit-CC: Nicholas Shahan <nsh...@google.com>
Gerrit-CC: Stephen Adams <s...@google.com>
Gerrit-CC: Tess Strickland <sstr...@google.com>
Gerrit-Attention: Alexander Markov <alexm...@google.com>
Gerrit-Comment-Date: Mon, 09 Mar 2026 19:23:46 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Alexander Markov (Gerrit)

unread,
Mar 9, 2026, 3:30:12 PM (14 hours ago) Mar 9
to Alexander Markov, Slava Egorov, Nate Biggs, Nicholas Shahan, Stephen Adams, Tess Strickland, Alexander Aprelev, Commit Queue, rev...@dartlang.org

Alexander Markov voted and added 1 comment

Votes added by Alexander Markov

Commit-Queue+2

1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Alexander Markov . resolved

Thank you, Slava!

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Ic922522f77624ede28b05ab6c9e67f33c82859c9
Gerrit-Change-Number: 486281
Gerrit-PatchSet: 2
Gerrit-Owner: Alexander Markov <alexm...@google.com>
Gerrit-Reviewer: Alexander Markov <alexm...@google.com>
Gerrit-Reviewer: Slava Egorov <veg...@google.com>
Gerrit-CC: Alexander Aprelev <a...@google.com>
Gerrit-CC: Nate Biggs <nate...@google.com>
Gerrit-CC: Nicholas Shahan <nsh...@google.com>
Gerrit-CC: Stephen Adams <s...@google.com>
Gerrit-CC: Tess Strickland <sstr...@google.com>
Gerrit-Comment-Date: Mon, 09 Mar 2026 19:30:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Commit Queue (Gerrit)

unread,
Mar 9, 2026, 4:02:02 PM (14 hours ago) Mar 9
to Alexander Markov, Slava Egorov, Nate Biggs, Nicholas Shahan, Stephen Adams, Tess Strickland, Alexander Aprelev, rev...@dartlang.org

Commit Queue submitted the change

Change information

Commit message:
[modular_aot] Code generation for binary int operations add/sub/mul/or/and/xor
Change-Id: Ic922522f77624ede28b05ab6c9e67f33c82859c9
Commit-Queue: Alexander Markov <alexm...@google.com>
Reviewed-by: Slava Egorov <veg...@google.com>
Files:
  • M pkg/native_compiler/lib/back_end/arm64/assembler.dart
  • M pkg/native_compiler/lib/back_end/arm64/code_generator.dart
  • M pkg/native_compiler/test/back_end/arm64/assembler_test.dart
Change size: M
Delta: 3 files changed, 149 insertions(+), 5 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Slava Egorov
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Ic922522f77624ede28b05ab6c9e67f33c82859c9
Gerrit-Change-Number: 486281
Gerrit-PatchSet: 3
Gerrit-Owner: Alexander Markov <alexm...@google.com>
Gerrit-Reviewer: Alexander Markov <alexm...@google.com>
Gerrit-Reviewer: Slava Egorov <veg...@google.com>
Gerrit-CC: Alexander Aprelev <a...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages