[XL] Change in dart/sdk[main]: CQ. Migrate diagnostics tests to resolveTestCodeWithDiagnostics. DEFG.
0 views
Skip to first unread message
SLSA Policy Verification Service (Gerrit)
May 10, 2026, 11:08:17 PM (2 days ago) May 10
to Konstantin Shcheglov, dart-analys...@google.com, rev...@dartlang.org
SLSA Policy Verification Service voted SLSA-Policy-Verified+1![]( "Open in Gerrit")
| SLSA-Policy-Verified | +1 |
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
SLSA Policy Verification Service (Gerrit)
May 10, 2026, 11:15:25 PM (2 days ago) May 10
to Konstantin Shcheglov, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Konstantin Shcheglov
SLSA Policy Verification Service voted SLSA-Policy-Verified+1![]( "Open in Gerrit")
| SLSA-Policy-Verified | +1 |
Related details
Attention is currently required from:
- Konstantin Shcheglov
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Johnni Winther (Gerrit)
May 11, 2026, 8:08:08 AM (2 days ago) May 11
to Konstantin Shcheglov, Paul Berry, SLSA Policy Verification Service, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Konstantin Shcheglov and Paul Berry
Johnni Winther voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Konstantin Shcheglov
- Paul Berry
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
SLSA Policy Verification Service (Gerrit)
May 12, 2026, 10:19:05 PM (11 hours ago) May 12
to Konstantin Shcheglov, Johnni Winther, Paul Berry, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Konstantin Shcheglov and Paul Berry
SLSA Policy Verification Service voted SLSA-Policy-Verified+1![]( "Open in Gerrit")
| SLSA-Policy-Verified | +1 |
Related details
Attention is currently required from:
- Konstantin Shcheglov
- Paul Berry
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Konstantin Shcheglov (Gerrit)
May 12, 2026, 10:19:26 PM (11 hours ago) May 12
to SLSA Policy Verification Service, Johnni Winther, Paul Berry, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Paul Berry
Konstantin Shcheglov voted Commit-Queue+2![]( "Open in Gerrit")
Attention is currently required from:
- Paul Berry
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
May 12, 2026, 10:52:26 PM (10 hours ago) May 12
to Konstantin Shcheglov, SLSA Policy Verification Service, Johnni Winther, Paul Berry, dart-analys...@google.com, rev...@dartlang.org
dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
2 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: pkg/analyzer/test/src/diagnostics/deprecated_factory_method_test.dart
Insertions: 5, Deletions: 1.
The diff is too large to show. Please review the diff.
```
Change information
Commit message:
CQ. Migrate diagnostics tests to resolveTestCodeWithDiagnostics. DEFG.
Change-Id: Ic3af506661e6a67a43a6a9046fb3bddeb268c0a6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/502540
Commit-Queue: Konstantin Shcheglov <sche...@google.com>
Reviewed-by: Johnni Winther <johnni...@google.com>
SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritco...@google.com>
Files:
- M pkg/analyzer/test/src/diagnostics/dead_code_test.dart
- M pkg/analyzer/test/src/diagnostics/dead_null_aware_expression_test.dart
- M pkg/analyzer/test/src/diagnostics/default_value_in_function_type_test.dart
- M pkg/analyzer/test/src/diagnostics/default_value_in_redirecting_factory_constructor_test.dart
- M pkg/analyzer/test/src/diagnostics/default_value_on_required_parameter_test.dart
- M pkg/analyzer/test/src/diagnostics/deferred_import_of_extension_test.dart
- M pkg/analyzer/test/src/diagnostics/definitely_unassigned_late_local_variable_test.dart
- M pkg/analyzer/test/src/diagnostics/deprecated_colon_for_default_value_test.dart
- M pkg/analyzer/test/src/diagnostics/deprecated_export_use_test.dart
- M pkg/analyzer/test/src/diagnostics/deprecated_extend_test.dart
- M pkg/analyzer/test/src/diagnostics/deprecated_extends_function_test.dart
- M pkg/analyzer/test/src/diagnostics/deprecated_factory_method_test.dart
- M pkg/analyzer/test/src/diagnostics/deprecated_implement_test.dart
- M pkg/analyzer/test/src/diagnostics/deprecated_implements_function_test.dart
- M pkg/analyzer/test/src/diagnostics/deprecated_instantiate_test.dart
- M pkg/analyzer/test/src/diagnostics/deprecated_member_use_test.dart
- M pkg/analyzer/test/src/diagnostics/deprecated_mixin_function_test.dart
- M pkg/analyzer/test/src/diagnostics/deprecated_mixin_test.dart
- M pkg/analyzer/test/src/diagnostics/deprecated_optional_test.dart
- M pkg/analyzer/test/src/diagnostics/deprecated_subclass_test.dart
- M pkg/analyzer/test/src/diagnostics/doc_directive_argument_wrong_format_test.dart
- M pkg/analyzer/test/src/diagnostics/doc_directive_has_extra_arguments_test.dart
- M pkg/analyzer/test/src/diagnostics/doc_directive_has_unexpected_named_argument_test.dart
- M pkg/analyzer/test/src/diagnostics/doc_directive_missing_one_argument_test.dart
- M pkg/analyzer/test/src/diagnostics/doc_directive_missing_three_arguments_test.dart
- M pkg/analyzer/test/src/diagnostics/doc_directive_missing_two_arguments_test.dart
- M pkg/analyzer/test/src/diagnostics/doc_import_cannot_be_deferred_test.dart
- M pkg/analyzer/test/src/diagnostics/doc_import_cannot_have_combinators_test.dart
- M pkg/analyzer/test/src/diagnostics/doc_import_cannot_have_configurations_test.dart
- M pkg/analyzer/test/src/diagnostics/doc_import_cannot_have_prefix_test.dart
- M pkg/analyzer/test/src/diagnostics/duplicate_constructor_default_test.dart
- M pkg/analyzer/test/src/diagnostics/duplicate_constructor_name_test.dart
- M pkg/analyzer/test/src/diagnostics/duplicate_field_formal_parameter_test.dart
- M pkg/analyzer/test/src/diagnostics/duplicate_field_name_test.dart
- M pkg/analyzer/test/src/diagnostics/duplicate_hidden_name_test.dart
- M pkg/analyzer/test/src/diagnostics/duplicate_ignore_test.dart
- M pkg/analyzer/test/src/diagnostics/duplicate_import_test.dart
- M pkg/analyzer/test/src/diagnostics/duplicate_named_argument_test.dart
- M pkg/analyzer/test/src/diagnostics/duplicate_part_test.dart
- M pkg/analyzer/test/src/diagnostics/duplicate_pattern_assignment_variable_test.dart
- M pkg/analyzer/test/src/diagnostics/duplicate_pattern_field_test.dart
- M pkg/analyzer/test/src/diagnostics/duplicate_private_named_parameter_test.dart
- M pkg/analyzer/test/src/diagnostics/duplicate_rest_element_in_pattern_test.dart
- M pkg/analyzer/test/src/diagnostics/duplicate_shown_name_test.dart
- M pkg/analyzer/test/src/diagnostics/duplicate_variable_pattern_test.dart
- M pkg/analyzer/test/src/diagnostics/enum_constant_invokes_factory_constructor_test.dart
- M pkg/analyzer/test/src/diagnostics/enum_constant_same_name_as_enclosing_test.dart
- M pkg/analyzer/test/src/diagnostics/enum_instantiated_to_bounds_is_not_well_bounded_test.dart
- M pkg/analyzer/test/src/diagnostics/enum_mixin_with_instance_variable_test.dart
- M pkg/analyzer/test/src/diagnostics/enum_with_abstract_member_test.dart
- M pkg/analyzer/test/src/diagnostics/enum_with_name_values_test.dart
- M pkg/analyzer/test/src/diagnostics/enum_without_constants_test.dart
- M pkg/analyzer/test/src/diagnostics/equal_elements_in_const_set_test.dart
- M pkg/analyzer/test/src/diagnostics/equal_elements_in_set_test.dart
- M pkg/analyzer/test/src/diagnostics/equal_keys_in_const_map_test.dart
- M pkg/analyzer/test/src/diagnostics/equal_keys_in_map_pattern_test.dart
- M pkg/analyzer/test/src/diagnostics/equal_keys_in_map_test.dart
- M pkg/analyzer/test/src/diagnostics/expected_one_list_pattern_type_arguments_test.dart
- M pkg/analyzer/test/src/diagnostics/expected_one_list_type_arguments_test.dart
- M pkg/analyzer/test/src/diagnostics/expected_one_set_type_arguments_test.dart
- M pkg/analyzer/test/src/diagnostics/expected_two_map_pattern_type_arguments_test.dart
- M pkg/analyzer/test/src/diagnostics/expected_two_map_type_arguments_test.dart
- M pkg/analyzer/test/src/diagnostics/experiment_not_enabled_test.dart
- M pkg/analyzer/test/src/diagnostics/experimental_member_use_test.dart
- M pkg/analyzer/test/src/diagnostics/export_internal_library_test.dart
- M pkg/analyzer/test/src/diagnostics/export_of_non_library_test.dart
- M pkg/analyzer/test/src/diagnostics/expression_in_map_test.dart
- M pkg/analyzer/test/src/diagnostics/extends_deferred_class_test.dart
- M pkg/analyzer/test/src/diagnostics/extends_disallowed_class_test.dart
- M pkg/analyzer/test/src/diagnostics/extends_non_class_test.dart
- M pkg/analyzer/test/src/diagnostics/extends_type_alias_expands_to_type_parameter_test.dart
- M pkg/analyzer/test/src/diagnostics/extension_as_expression_test.dart
- M pkg/analyzer/test/src/diagnostics/extension_conflicting_static_and_instance_test.dart
- M pkg/analyzer/test/src/diagnostics/extension_declares_abstract_method_test.dart
- M pkg/analyzer/test/src/diagnostics/extension_declares_constructor_test.dart
- M pkg/analyzer/test/src/diagnostics/extension_declares_field_test.dart
- M pkg/analyzer/test/src/diagnostics/extension_declares_member_of_object_test.dart
- M pkg/analyzer/test/src/diagnostics/extension_override_access_to_static_member_test.dart
- M pkg/analyzer/test/src/diagnostics/extension_override_argument_not_assignable_test.dart
- M pkg/analyzer/test/src/diagnostics/extension_override_with_cascade_test.dart
- M pkg/analyzer/test/src/diagnostics/extension_override_without_access_test.dart
- M pkg/analyzer/test/src/diagnostics/extension_type_constructor_with_super_formal_parameter_test.dart
- M pkg/analyzer/test/src/diagnostics/extension_type_constructor_with_super_invocation_test.dart
- M pkg/analyzer/test/src/diagnostics/extension_type_declares_instance_field_test.dart
- M pkg/analyzer/test/src/diagnostics/extension_type_declares_member_of_object_test.dart
- M pkg/analyzer/test/src/diagnostics/extension_type_implements_disallowed_type_test.dart
- M pkg/analyzer/test/src/diagnostics/extension_type_implements_itself_test.dart
- M pkg/analyzer/test/src/diagnostics/extension_type_implements_not_supertype_of_erasure_test.dart
- M pkg/analyzer/test/src/diagnostics/extension_type_implements_representation_not_supertype_test.dart
- M pkg/analyzer/test/src/diagnostics/extension_type_inherited_member_conflict_test.dart
- M pkg/analyzer/test/src/diagnostics/extension_type_representation_depends_on_itself_test.dart
- M pkg/analyzer/test/src/diagnostics/extension_type_representation_type_bottom_test.dart
- M pkg/analyzer/test/src/diagnostics/extension_type_with_abstract_member_test.dart
- M pkg/analyzer/test/src/diagnostics/external_field_constructor_initializer_test.dart
- M pkg/analyzer/test/src/diagnostics/external_method_with_body_test.dart
- M pkg/analyzer/test/src/diagnostics/extra_annotation_on_struct_field_test.dart
- M pkg/analyzer/test/src/diagnostics/extra_positional_arguments_test.dart
- M pkg/analyzer/test/src/diagnostics/extra_size_annotation_carray_test.dart
- M pkg/analyzer/test/src/diagnostics/ffi_address_of_cast_test.dart
- M pkg/analyzer/test/src/diagnostics/ffi_array_test.dart
- M pkg/analyzer/test/src/diagnostics/ffi_async_callback_test.dart
- M pkg/analyzer/test/src/diagnostics/ffi_leaf_call_must_not_use_handle_test.dart
- M pkg/analyzer/test/src/diagnostics/ffi_native_test.dart
- M pkg/analyzer/test/src/diagnostics/field_initializer_factory_constructor_test.dart
- M pkg/analyzer/test/src/diagnostics/field_initializer_not_assignable_test.dart
- M pkg/analyzer/test/src/diagnostics/field_initializer_outside_constructor_test.dart
- M pkg/analyzer/test/src/diagnostics/field_initializer_redirecting_constructor_test.dart
- M pkg/analyzer/test/src/diagnostics/field_initializing_formal_not_assignable_test.dart
- M pkg/analyzer/test/src/diagnostics/field_must_be_external_in_struct_test.dart
- M pkg/analyzer/test/src/diagnostics/final_class_extended_outside_of_library_test.dart
- M pkg/analyzer/test/src/diagnostics/final_class_implemented_outside_of_library_test.dart
- M pkg/analyzer/test/src/diagnostics/final_class_used_as_mixin_constraint_outside_of_library_test.dart
- M pkg/analyzer/test/src/diagnostics/for_in_of_invalid_element_type_test.dart
- M pkg/analyzer/test/src/diagnostics/for_in_of_invalid_type_test.dart
- M pkg/analyzer/test/src/diagnostics/for_in_with_const_variable_test.dart
- M pkg/analyzer/test/src/diagnostics/generic_function_type_cannot_be_bound_test.dart
- M pkg/analyzer/test/src/diagnostics/generic_struct_subclass_test.dart
- M pkg/analyzer/test/src/diagnostics/getter_not_subtype_setter_types_test.dart
Change size: XL
Delta: 118 files changed, 5131 insertions(+), 6509 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Johnni Winther
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages