[XS] Change in dart/sdk[main]: [VM/Service] Tweak profile_startup_cli_flag_test to make it less flaky
0 views
Skip to first unread message
Derek Xu (Gerrit)
Aug 8, 2025, 12:55:24 PMAug 8
to Ben Konyi, rev...@dartlang.org
Attention needed from Ben Konyi
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Ben Konyi
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ben Konyi (Gerrit)
Aug 11, 2025, 3:55:41 PMAug 11
to Derek Xu, rev...@dartlang.org
Attention needed from Derek Xu
Ben Konyi voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Derek Xu
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Derek Xu (Gerrit)
Aug 11, 2025, 4:05:52 PMAug 11
to Ben Konyi, rev...@dartlang.org
Derek Xu voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Commit Queue (Gerrit)
Aug 11, 2025, 4:33:49 PMAug 11
to Derek Xu, Ben Konyi, rev...@dartlang.org
Commit Queue submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[VM/Service] Tweak profile_startup_cli_flag_test to make it less flaky
This is a followup to
https://github.com/dart-lang/sdk/commit/1ddbc4428829f126a7963ca11763bec90187fe5f
that follows the same rationale described in that commit’s message. This
followup is being made because the original change did not successfully
resolve the flakiness on Windows configurations. If the flakiness is
still present after this change lands, we probably have to replace this
`package:vm_service` integration test with a C++ test that interacts
directly with a `SampleBlockBuffer`.
Change-Id: Ifc3029dbd23b3bcfaac947d3b3f6bd54b973eb05
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/444443
Reviewed-by: Ben Konyi <bko...@google.com>
Commit-Queue: Derek Xu <der...@google.com>
Files:
- M pkg/vm_service/test/profile_startup_cli_flag_test.dart
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Ben Konyi
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages