[XS] Change in dart/sdk[main]: [VM/Service] Tweak profile_startup_cli_flag_test to make it less flaky

0 views
Skip to first unread message

Derek Xu (Gerrit)

unread,
Aug 8, 2025, 12:55:24 PMAug 8
to Ben Konyi, rev...@dartlang.org
Attention needed from Ben Konyi

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Ben Konyi
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Ifc3029dbd23b3bcfaac947d3b3f6bd54b973eb05
Gerrit-Change-Number: 444443
Gerrit-PatchSet: 3
Gerrit-Owner: Derek Xu <der...@google.com>
Gerrit-Reviewer: Ben Konyi <bko...@google.com>
Gerrit-Attention: Ben Konyi <bko...@google.com>
Gerrit-Comment-Date: Fri, 08 Aug 2025 16:55:22 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Ben Konyi (Gerrit)

unread,
Aug 11, 2025, 3:55:41 PMAug 11
to Derek Xu, rev...@dartlang.org
Attention needed from Derek Xu

Ben Konyi voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Derek Xu
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Ifc3029dbd23b3bcfaac947d3b3f6bd54b973eb05
Gerrit-Change-Number: 444443
Gerrit-PatchSet: 3
Gerrit-Owner: Derek Xu <der...@google.com>
Gerrit-Reviewer: Ben Konyi <bko...@google.com>
Gerrit-Attention: Derek Xu <der...@google.com>
Gerrit-Comment-Date: Mon, 11 Aug 2025 19:55:38 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Derek Xu (Gerrit)

unread,
Aug 11, 2025, 4:05:52 PMAug 11
to Ben Konyi, rev...@dartlang.org

Derek Xu voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Ifc3029dbd23b3bcfaac947d3b3f6bd54b973eb05
Gerrit-Change-Number: 444443
Gerrit-PatchSet: 3
Gerrit-Owner: Derek Xu <der...@google.com>
Gerrit-Reviewer: Ben Konyi <bko...@google.com>
Gerrit-Reviewer: Derek Xu <der...@google.com>
Gerrit-Comment-Date: Mon, 11 Aug 2025 20:05:49 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Commit Queue (Gerrit)

unread,
Aug 11, 2025, 4:33:49 PMAug 11
to Derek Xu, Ben Konyi, rev...@dartlang.org

Commit Queue submitted the change

Change information

Commit message:
[VM/Service] Tweak profile_startup_cli_flag_test to make it less flaky

This is a followup to
https://github.com/dart-lang/sdk/commit/1ddbc4428829f126a7963ca11763bec90187fe5f
that follows the same rationale described in that commit’s message. This
followup is being made because the original change did not successfully
resolve the flakiness on Windows configurations. If the flakiness is
still present after this change lands, we probably have to replace this
`package:vm_service` integration test with a C++ test that interacts
directly with a `SampleBlockBuffer`.
Change-Id: Ifc3029dbd23b3bcfaac947d3b3f6bd54b973eb05
Reviewed-by: Ben Konyi <bko...@google.com>
Commit-Queue: Derek Xu <der...@google.com>
Files:
  • M pkg/vm_service/test/profile_startup_cli_flag_test.dart
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Ben Konyi
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Ifc3029dbd23b3bcfaac947d3b3f6bd54b973eb05
Gerrit-Change-Number: 444443
Gerrit-PatchSet: 4
Gerrit-Owner: Derek Xu <der...@google.com>
Gerrit-Reviewer: Ben Konyi <bko...@google.com>
Gerrit-Reviewer: Derek Xu <der...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages