[L] Change in dart/sdk[main]: [analysis_server] Ensure cancellation tokens are passed down through ...
1 view
Skip to first unread message
Samuel Rawlins (Gerrit)
Oct 22, 2026, 4:19:44 PM (6 days ago) Oct 22
to Danny Tuppeny, Keerti Parthasarathy, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Danny Tuppeny and Keerti Parthasarathy
Samuel Rawlins voted and added 1 comment on change 567961![]( "Open in Gerrit")
Votes added by Samuel Rawlins <sraw...@google.com>
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Danny Tuppeny
- Keerti Parthasarathy
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Danny Tuppeny (Gerrit)
Oct 27, 2026, 7:27:02 AM (22 hours ago) Oct 27
to Samuel Rawlins, Keerti Parthasarathy, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Keerti Parthasarathy and Samuel Rawlins
Danny Tuppeny added 1 comment on change 567961![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 3 (Latest):
Danny Tuppeny . resolved
There was a minor conflict because I added a cancellation check here in code that was removed on `main`. I've rebased and resolved that.
Related details
Attention is currently required from:
- Keerti Parthasarathy
- Samuel Rawlins
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Samuel Rawlins (Gerrit)
Oct 27, 2026, 11:08:50 AM (19 hours ago) Oct 27
to Danny Tuppeny, Keerti Parthasarathy, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Danny Tuppeny and Keerti Parthasarathy
Samuel Rawlins voted Code-Review+1 on change 567961![]( "Open in Gerrit")
Attention is currently required from:
- Danny Tuppeny
- Keerti Parthasarathy
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Keerti Parthasarathy (Gerrit)
Oct 27, 2026, 1:42:15 PM (16 hours ago) Oct 27
to Danny Tuppeny, dart-...@luci-project-accounts.iam.gserviceaccount.com, Samuel Rawlins, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Danny Tuppeny
Keerti Parthasarathy voted and added 1 comment on change 567961![]( "Open in Gerrit")
Votes added by Keerti Parthasarathy <kee...@google.com>
| Code-Review | +1 |
1 comment
Patchset-level comments
Keerti Parthasarathy . resolved
Nice!
Related details
Attention is currently required from:
- Danny Tuppeny
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Keerti Parthasarathy (Gerrit)
Oct 27, 2026, 1:42:24 PM (16 hours ago) Oct 27
to Danny Tuppeny, dart-...@luci-project-accounts.iam.gserviceaccount.com, Samuel Rawlins, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Danny Tuppeny
Keerti Parthasarathy voted Commit-Queue+2 on change 567961![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Danny Tuppeny
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
Oct 27, 2026, 1:47:41 PM (16 hours ago) Oct 27
to Danny Tuppeny, Keerti Parthasarathy, Samuel Rawlins, dart-analys...@google.com, rev...@dartlang.org
dart-...@luci-project-accounts.iam.gserviceaccount.com submitted change 567961![]( "Open in Gerrit")
Change information
Commit message:
[analysis_server] Ensure cancellation tokens are passed down through code action handling
This is particularly beneficial for requests like this that are sent as the user is typing, because they are likely to frequently be cancelled as the user continues to type.
See https://github.com/dart-lang/sdk/issues/64643
Change-Id: I4edcf1ad2bc018545e9eb78a572b96b5464dc639
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/567961
Reviewed-by: Samuel Rawlins <sraw...@google.com>
Reviewed-by: Keerti Parthasarathy <kee...@google.com>
Commit-Queue: Keerti Parthasarathy <kee...@google.com>
Files:
- M pkg/analysis_server/lib/src/lsp/handlers/code_actions/abstract_code_actions_producer.dart
- M pkg/analysis_server/lib/src/lsp/handlers/code_actions/analysis_options.dart
- M pkg/analysis_server/lib/src/lsp/handlers/code_actions/code_action_computer.dart
- M pkg/analysis_server/lib/src/lsp/handlers/code_actions/dart.dart
- M pkg/analysis_server/lib/src/lsp/handlers/code_actions/plugins.dart
- M pkg/analysis_server/lib/src/lsp/handlers/code_actions/pubspec.dart
- M pkg/analysis_server/lib/src/lsp/handlers/commands/apply_code_action.dart
- M pkg/analysis_server/lib/src/lsp/handlers/handler_code_actions.dart
- M pkg/analysis_server/lib/src/services/refactoring/framework/refactoring_processor.dart
- M pkg/analysis_server_plugin/lib/src/correction/assist_processor.dart
- M pkg/analysis_server_plugin/lib/src/correction/fix_in_file_processor.dart
- M pkg/analysis_server_plugin/lib/src/correction/fix_processor.dart
Change size: L
Delta: 12 files changed, 221 insertions(+), 98 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Samuel Rawlins, +1 by Keerti Parthasarathy
Review-Enforcement: Code-Review+1 by Samuel Rawlins, Code-Review+1 by Keerti Parthasarathy
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages