[XS] Change in dart/sdk[main]: Fix Fuchsia build.

0 views
Skip to first unread message

Ryan Macnak (Gerrit)

unread,
6:56 PM (4 hours ago) 6:56 PM
to Liam Appelbe, rev...@dartlang.org
Attention needed from Liam Appelbe

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Liam Appelbe
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Ic252a43407d7d944e50e327fb6bfd8cb406fb035
Gerrit-Change-Number: 516520
Gerrit-PatchSet: 3
Gerrit-Owner: Ryan Macnak <rma...@google.com>
Gerrit-Reviewer: Liam Appelbe <li...@google.com>
Gerrit-Attention: Liam Appelbe <li...@google.com>
Gerrit-Comment-Date: Tue, 23 Jun 2026 22:56:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Liam Appelbe (Gerrit)

unread,
6:58 PM (4 hours ago) 6:58 PM
to Ryan Macnak, Liam Appelbe, rev...@dartlang.org
Attention needed from Ryan Macnak

Liam Appelbe voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Ryan Macnak
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Ic252a43407d7d944e50e327fb6bfd8cb406fb035
Gerrit-Change-Number: 516520
Gerrit-PatchSet: 3
Gerrit-Owner: Ryan Macnak <rma...@google.com>
Gerrit-Reviewer: Liam Appelbe <li...@google.com>
Gerrit-Attention: Ryan Macnak <rma...@google.com>
Gerrit-Comment-Date: Tue, 23 Jun 2026 22:58:16 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Ryan Macnak (Gerrit)

unread,
7:11 PM (3 hours ago) 7:11 PM
to Liam Appelbe, rev...@dartlang.org

Ryan Macnak voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Ic252a43407d7d944e50e327fb6bfd8cb406fb035
Gerrit-Change-Number: 516520
Gerrit-PatchSet: 3
Gerrit-Owner: Ryan Macnak <rma...@google.com>
Gerrit-Reviewer: Liam Appelbe <li...@google.com>
Gerrit-Reviewer: Ryan Macnak <rma...@google.com>
Gerrit-Comment-Date: Tue, 23 Jun 2026 23:11:11 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)

unread,
8:53 PM (2 hours ago) 8:53 PM
to Ryan Macnak, Liam Appelbe, rev...@dartlang.org

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change

Change information

Commit message:
Fix Fuchsia build.

New tests added in 9eeefc7b383b36e2505b349ccf82ab64b6c34813 and 223176c250ff2c62c6d8adf1f93e6d42ab0bf4ad were not also added to the Fuchsia package.
Change-Id: Ic252a43407d7d944e50e327fb6bfd8cb406fb035
Commit-Queue: Ryan Macnak <rma...@google.com>
Reviewed-by: Liam Appelbe <li...@google.com>
Files:
  • M BUILD.gn
Change size: XS
Delta: 1 file changed, 2 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Liam Appelbe
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Ic252a43407d7d944e50e327fb6bfd8cb406fb035
Gerrit-Change-Number: 516520
Gerrit-PatchSet: 4
Gerrit-Owner: Ryan Macnak <rma...@google.com>
Gerrit-Reviewer: Liam Appelbe <li...@google.com>
Gerrit-Reviewer: Ryan Macnak <rma...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages