[M] Change in dart/sdk[main]: [DAS] Fixes `Add missing Switch cases` not importing src libraries

0 views
Skip to first unread message

Felipe Morschel (Gerrit)

unread,
Sep 24, 2025, 2:32:43 PM (5 days ago) Sep 24
to dart-analys...@google.com, rev...@dartlang.org

Felipe Morschel has uploaded the change for review

Commit message

[DAS] Fixes `Add missing Switch cases` not importing src libraries
Change-Id: I6ca063aeaad2b6ce994c8637da653561231b1fdf

Change information

Files:
  • M pkg/analysis_server/lib/src/services/correction/dart/add_missing_switch_cases.dart
  • M pkg/analysis_server/test/src/services/correction/fix/add_missing_switch_cases_test.dart
Change size: M
Delta: 2 files changed, 67 insertions(+), 8 deletions(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I6ca063aeaad2b6ce994c8637da653561231b1fdf
Gerrit-Change-Number: 451340
Gerrit-PatchSet: 1
Gerrit-Owner: Felipe Morschel <g...@fmorschel.dev>
Gerrit-Reviewer: Felipe Morschel <g...@fmorschel.dev>
unsatisfied_requirement
open
diffy

Brian Wilkerson (Gerrit)

unread,
Sep 26, 2025, 3:01:37 PM (3 days ago) Sep 26
to Felipe Morschel, Brian Wilkerson, Samuel Rawlins, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Felipe Morschel and Samuel Rawlins

Brian Wilkerson voted

Code-Review+1
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Felipe Morschel
  • Samuel Rawlins
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I6ca063aeaad2b6ce994c8637da653561231b1fdf
Gerrit-Change-Number: 451340
Gerrit-PatchSet: 1
Gerrit-Owner: Felipe Morschel <g...@fmorschel.dev>
Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
Gerrit-Reviewer: Felipe Morschel <g...@fmorschel.dev>
Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
Gerrit-Attention: Felipe Morschel <g...@fmorschel.dev>
Gerrit-Attention: Samuel Rawlins <sraw...@google.com>
Gerrit-Comment-Date: Fri, 26 Sep 2025 19:01:33 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Samuel Rawlins (Gerrit)

unread,
Sep 26, 2025, 3:31:32 PM (3 days ago) Sep 26
to Felipe Morschel, Commit Queue, Brian Wilkerson, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Felipe Morschel

Samuel Rawlins voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Felipe Morschel
Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: I6ca063aeaad2b6ce994c8637da653561231b1fdf
    Gerrit-Change-Number: 451340
    Gerrit-PatchSet: 1
    Gerrit-Owner: Felipe Morschel <g...@fmorschel.dev>
    Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
    Gerrit-Reviewer: Felipe Morschel <g...@fmorschel.dev>
    Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
    Gerrit-Attention: Felipe Morschel <g...@fmorschel.dev>
    Gerrit-Comment-Date: Fri, 26 Sep 2025 19:31:28 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Commit Queue (Gerrit)

    unread,
    Sep 26, 2025, 3:41:14 PM (3 days ago) Sep 26
    to Felipe Morschel, Samuel Rawlins, Brian Wilkerson, dart-analys...@google.com, rev...@dartlang.org

    Commit Queue submitted the change

    Change information

    Commit message:
    [DAS] Fixes `Add missing Switch cases` not importing src libraries
    Change-Id: I6ca063aeaad2b6ce994c8637da653561231b1fdf
    Auto-Submit: Felipe Morschel <g...@fmorschel.dev>
    Reviewed-by: Samuel Rawlins <sraw...@google.com>
    Commit-Queue: Samuel Rawlins <sraw...@google.com>
    Reviewed-by: Brian Wilkerson <brianwi...@google.com>
    Files:
    • M pkg/analysis_server/lib/src/services/correction/dart/add_missing_switch_cases.dart
    • M pkg/analysis_server/test/src/services/correction/fix/add_missing_switch_cases_test.dart
    Change size: M
    Delta: 2 files changed, 67 insertions(+), 8 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Brian Wilkerson, +1 by Samuel Rawlins
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: I6ca063aeaad2b6ce994c8637da653561231b1fdf
    Gerrit-Change-Number: 451340
    Gerrit-PatchSet: 2
    Gerrit-Owner: Felipe Morschel <g...@fmorschel.dev>
    Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages