[M] Change in dart/sdk[main]: DeCo. Report missingPrimaryConstructorParameters when has primary con...
0 views
Skip to first unread message
Johnni Winther (Gerrit)
Jun 23, 2026, 6:56:41 AM (2 days ago) Jun 23
to Konstantin Shcheglov, Paul Berry, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-analys...@google.com, dart-fe-te...@google.com, rev...@dartlang.org
Attention needed from Konstantin Shcheglov and Paul Berry
Johnni Winther voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Konstantin Shcheglov
- Paul Berry
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Konstantin Shcheglov (Gerrit)
Jun 23, 2026, 12:26:39 PM (2 days ago) Jun 23
to Johnni Winther, Paul Berry, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-analys...@google.com, dart-fe-te...@google.com, rev...@dartlang.org
Attention needed from Paul Berry
Konstantin Shcheglov voted Commit-Queue+2![]( "Open in Gerrit")
Attention is currently required from:
- Paul Berry
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
Jun 23, 2026, 1:26:24 PM (2 days ago) Jun 23
to Konstantin Shcheglov, Johnni Winther, Paul Berry, dart-analys...@google.com, dart-fe-te...@google.com, rev...@dartlang.org
dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Change information
Commit message:
DeCo. Report missingPrimaryConstructorParameters when has primary constructor name, but no formal parameters.
Change-Id: Ic079bbbfcd282721f2e58596643dca6679dc2f8b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/515460
Reviewed-by: Johnni Winther <johnni...@google.com>
Commit-Queue: Konstantin Shcheglov <sche...@google.com>
Files:
- M pkg/_fe_analyzer_shared/lib/src/parser/parser_impl.dart
- M pkg/analyzer/test/src/dart/parser/class_test.dart
- M pkg/analyzer/test/src/dart/parser/enum_test.dart
- M pkg/front_end/parser_testcases/primary_constructors/class_primary_constructor_error.dart.expect
- M pkg/front_end/parser_testcases/primary_constructors/class_primary_constructor_error.dart.intertwined.expect
- M pkg/front_end/parser_testcases/primary_constructors/enum_primary_constructor_error.dart.expect
- M pkg/front_end/parser_testcases/primary_constructors/enum_primary_constructor_error.dart.intertwined.expect
Change size: M
Delta: 7 files changed, 160 insertions(+), 3 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Johnni Winther
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages