[M] Change in dart/sdk[main]: Build devtools with a Python script, rather than Dart

0 views
Skip to first unread message

Samuel Rawlins (Gerrit)

unread,
Apr 21, 2026, 5:41:37 PM (18 hours ago) Apr 21
to Kenzie Davisson, Ivan Inozemtsev, dart-...@luci-project-accounts.iam.gserviceaccount.com, rev...@dartlang.org
Attention needed from Ivan Inozemtsev and Kenzie Davisson

Samuel Rawlins added 1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Samuel Rawlins . resolved

Friendly ping 😊

Open in Gerrit

Related details

Attention is currently required from:
  • Ivan Inozemtsev
  • Kenzie Davisson
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I767aaf42d1584ae331d028ef073a534e5d36b77b
Gerrit-Change-Number: 496402
Gerrit-PatchSet: 2
Gerrit-Owner: Samuel Rawlins <sraw...@google.com>
Gerrit-Reviewer: Ivan Inozemtsev <iinoz...@google.com>
Gerrit-Reviewer: Kenzie Davisson <kenzie...@google.com>
Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
Gerrit-Attention: Kenzie Davisson <kenzie...@google.com>
Gerrit-Attention: Ivan Inozemtsev <iinoz...@google.com>
Gerrit-Comment-Date: Tue, 21 Apr 2026 21:41:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Kenzie Davisson (Gerrit)

unread,
11:21 AM (3 minutes ago) 11:21 AM
to Samuel Rawlins, Alexander Thomas, Ivan Inozemtsev, dart-...@luci-project-accounts.iam.gserviceaccount.com, rev...@dartlang.org
Attention needed from Alexander Thomas, Ivan Inozemtsev and Samuel Rawlins

Kenzie Davisson added 3 comments

File tools/build_devtools.py
Line 44, Patchset 2 (Latest): flutter_bin_absolute = os.path.normpath(
Kenzie Davisson . unresolved

why are we finding this relative to devtools_app?

Line 61, Patchset 2 (Latest): dart_bin_relative = os.path.join('..', '..', '..', 'flutter', 'bin',
Kenzie Davisson . unresolved

it doesn't look like dart_bin_relative is used anywhere either

Line 66, Patchset 2 (Latest): dt_path_relative = os.path.join('..', '..', 'tool', 'bin', 'dt.dart')
Kenzie Davisson . unresolved

it doesn't look like this var is used anywhere

Open in Gerrit

Related details

Attention is currently required from:
  • Alexander Thomas
  • Ivan Inozemtsev
  • Samuel Rawlins
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I767aaf42d1584ae331d028ef073a534e5d36b77b
Gerrit-Change-Number: 496402
Gerrit-PatchSet: 2
Gerrit-Owner: Samuel Rawlins <sraw...@google.com>
Gerrit-Reviewer: Alexander Thomas <at...@google.com>
Gerrit-Reviewer: Ivan Inozemtsev <iinoz...@google.com>
Gerrit-Reviewer: Kenzie Davisson <kenzie...@google.com>
Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
Gerrit-Attention: Alexander Thomas <at...@google.com>
Gerrit-Attention: Ivan Inozemtsev <iinoz...@google.com>
Gerrit-Attention: Samuel Rawlins <sraw...@google.com>
Gerrit-Comment-Date: Wed, 22 Apr 2026 15:21:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages