[L] Change in dart/sdk[main]: [modular_aot] Closures, part 2
0 views
Skip to first unread message
Alexander Markov (Gerrit)
May 12, 2026, 5:07:25 PM (16 hours ago) May 12
to Alexander Markov, Slava Egorov, Nate Biggs, Nicholas Shahan, Alexander Aprelev, Tess Strickland, Stephen Adams, dart-...@luci-project-accounts.iam.gserviceaccount.com, rev...@dartlang.org
Attention needed from Slava Egorov
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Slava Egorov
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Slava Egorov (Gerrit)
6:53 AM (2 hours ago) 6:53 AM
to Alexander Markov, Nate Biggs, Nicholas Shahan, Alexander Aprelev, Tess Strickland, Stephen Adams, dart-...@luci-project-accounts.iam.gserviceaccount.com, rev...@dartlang.org
Attention needed from Alexander Markov
Slava Egorov voted and added 1 comment![]( "Open in Gerrit")
Votes added by Slava Egorov
| Code-Review | +1 |
1 comment
File pkg/cfg/testcases/capturing.dart.expect
Line 10, Patchset 2 (Latest):
v4 = AllocateContext()Slava Egorov . resolved
It's a very interesting example where we end up with unnecessary contexts.
Related details
Attention is currently required from:
- Alexander Markov
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alexander Markov (Gerrit)
8:58 AM (13 minutes ago) 8:58 AM
to Alexander Markov, Slava Egorov, Nate Biggs, Nicholas Shahan, Alexander Aprelev, Tess Strickland, Stephen Adams, dart-...@luci-project-accounts.iam.gserviceaccount.com, rev...@dartlang.org
Alexander Markov voted and added 2 comments![]( "Open in Gerrit")
Votes added by Alexander Markov
| Commit-Queue | +2 |
2 comments
Patchset-level comments
File pkg/cfg/testcases/capturing.dart.expect
Line 10, Patchset 2 (Latest):
v4 = AllocateContext()Slava Egorov . resolved
It's a very interesting example where we end up with unnecessary contexts.
Alexander Markov
Yeah, we should be able to capture `this` and other read-only variables by value and avoid allocating certain contexts. This is a future work, after switching to the new kernel AST encoding.
For mutable variable `i` we still need a context (unless closure call is inlined).
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
8:58 AM (13 minutes ago) 8:58 AM
to Alexander Markov, Slava Egorov, Nate Biggs, Nicholas Shahan, Alexander Aprelev, Tess Strickland, Stephen Adams, rev...@dartlang.org
dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[modular_aot] Closures, part 2
Change-Id: Id8029dddd75b5f771ddf8197190d18aea9efd192
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/503080
Commit-Queue: Alexander Markov <alexm...@google.com>
Reviewed-by: Slava Egorov <veg...@google.com>
Files:
- M pkg/cfg/lib/front_end/ast_to_ir.dart
- M pkg/cfg/lib/front_end/computed_scopes.dart
- M pkg/cfg/lib/ir/field.dart
- M pkg/cfg/lib/ir/flow_graph_builder.dart
- M pkg/cfg/lib/ir/flow_graph_checker.dart
- M pkg/cfg/lib/ir/functions.dart
- M pkg/cfg/lib/ir/instructions.dart
- M pkg/cfg/testcases/capturing.dart
- M pkg/cfg/testcases/capturing.dart.expect
- M pkg/native_compiler/lib/back_end/arm64/code_generator.dart
- M pkg/native_compiler/lib/back_end/arm64/constraints.dart
- M pkg/native_compiler/lib/runtime/type_utils.dart
- M pkg/native_compiler/testcases/register_allocator_test.dart.expect
Change size: L
Delta: 13 files changed, 481 insertions(+), 312 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Slava Egorov
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages