[L] Change in dart/sdk[main]: [parser][PrimaryConstructors] Support covariant on non-final declarin...

0 views
Skip to first unread message

Johnni Winther (Gerrit)

unread,
Jan 15, 2026, 8:59:30 AM (7 days ago) Jan 15
to Konstantin Shcheglov, Commit Queue, Paul Berry, dart-analys...@google.com, dart-fe-te...@google.com, rev...@dartlang.org
Attention needed from Konstantin Shcheglov

Johnni Winther voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Konstantin Shcheglov
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Ic592579e6499a30fb51d74af45bc294fb8213b3d
Gerrit-Change-Number: 472904
Gerrit-PatchSet: 3
Gerrit-Owner: Johnni Winther <johnni...@google.com>
Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
Gerrit-CC: Paul Berry <paul...@google.com>
Gerrit-Attention: Konstantin Shcheglov <sche...@google.com>
Gerrit-Comment-Date: Thu, 15 Jan 2026 13:59:26 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
unsatisfied_requirement
open
diffy

Konstantin Shcheglov (Gerrit)

unread,
Jan 15, 2026, 3:20:54 PM (6 days ago) Jan 15
to Johnni Winther, Commit Queue, Paul Berry, dart-analys...@google.com, dart-fe-te...@google.com, rev...@dartlang.org
Attention needed from Johnni Winther

Konstantin Shcheglov voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Johnni Winther
Submit Requirements:
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: Ic592579e6499a30fb51d74af45bc294fb8213b3d
    Gerrit-Change-Number: 472904
    Gerrit-PatchSet: 3
    Gerrit-Owner: Johnni Winther <johnni...@google.com>
    Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
    Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
    Gerrit-CC: Paul Berry <paul...@google.com>
    Gerrit-Attention: Johnni Winther <johnni...@google.com>
    Gerrit-Comment-Date: Thu, 15 Jan 2026 20:20:51 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    unsatisfied_requirement
    satisfied_requirement
    open
    diffy

    Brian Wilkerson (Gerrit)

    unread,
    Jan 16, 2026, 11:07:07 AM (6 days ago) Jan 16
    to Johnni Winther, Brian Wilkerson, Konstantin Shcheglov, Commit Queue, Paul Berry, dart-analys...@google.com, dart-fe-te...@google.com, rev...@dartlang.org
    Attention needed from Johnni Winther

    Brian Wilkerson voted and added 2 comments

    Votes added by Brian Wilkerson

    Code-Review+1

    2 comments

    Patchset-level comments
    File-level comment, Patchset 3 (Latest):
    Brian Wilkerson . resolved

    The server change lgtm. I added a minor suggestion on the message itself, but it isn't critical, and even if you decide to make the change can be done later.

    File pkg/_fe_analyzer_shared/messages.yaml
    Line 972, Patchset 3 (Latest): problemMessage: "'covariant' modifier can only be used on non-final declaring parameters."
    Brian Wilkerson . unresolved

    Consider adding "The" to start the sentence.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Johnni Winther
    Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: Ic592579e6499a30fb51d74af45bc294fb8213b3d
    Gerrit-Change-Number: 472904
    Gerrit-PatchSet: 3
    Gerrit-Owner: Johnni Winther <johnni...@google.com>
    Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
    Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
    Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
    Gerrit-CC: Paul Berry <paul...@google.com>
    Gerrit-Attention: Johnni Winther <johnni...@google.com>
    Gerrit-Comment-Date: Fri, 16 Jan 2026 16:07:04 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Johnni Winther (Gerrit)

    unread,
    Jan 21, 2026, 4:48:44 AM (19 hours ago) Jan 21
    to Brian Wilkerson, Konstantin Shcheglov, Commit Queue, Paul Berry, dart-analys...@google.com, dart-fe-te...@google.com, rev...@dartlang.org
    Attention needed from Brian Wilkerson and Konstantin Shcheglov

    Johnni Winther added 2 comments

    Patchset-level comments
    File-level comment, Patchset 4 (Latest):
    Johnni Winther . resolved

    Lost the +1s.

    File pkg/_fe_analyzer_shared/messages.yaml
    Line 972, Patchset 3: problemMessage: "'covariant' modifier can only be used on non-final declaring parameters."
    Brian Wilkerson . resolved

    Consider adding "The" to start the sentence.

    Johnni Winther

    Done

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Brian Wilkerson
    • Konstantin Shcheglov
    Submit Requirements:
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: sdk
      Gerrit-Branch: main
      Gerrit-Change-Id: Ic592579e6499a30fb51d74af45bc294fb8213b3d
      Gerrit-Change-Number: 472904
      Gerrit-PatchSet: 4
      Gerrit-Owner: Johnni Winther <johnni...@google.com>
      Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
      Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
      Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
      Gerrit-CC: Paul Berry <paul...@google.com>
      Gerrit-Attention: Brian Wilkerson <brianwi...@google.com>
      Gerrit-Attention: Konstantin Shcheglov <sche...@google.com>
      Gerrit-Comment-Date: Wed, 21 Jan 2026 09:48:38 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Brian Wilkerson <brianwi...@google.com>
      unsatisfied_requirement
      open
      diffy

      Brian Wilkerson (Gerrit)

      unread,
      Jan 21, 2026, 10:04:04 AM (14 hours ago) Jan 21
      to Johnni Winther, Brian Wilkerson, Konstantin Shcheglov, Commit Queue, Paul Berry, dart-analys...@google.com, dart-fe-te...@google.com, rev...@dartlang.org
      Attention needed from Johnni Winther and Konstantin Shcheglov

      Brian Wilkerson voted Code-Review+1

      Code-Review+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Johnni Winther
      • Konstantin Shcheglov
      Submit Requirements:
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: sdk
        Gerrit-Branch: main
        Gerrit-Change-Id: Ic592579e6499a30fb51d74af45bc294fb8213b3d
        Gerrit-Change-Number: 472904
        Gerrit-PatchSet: 4
        Gerrit-Owner: Johnni Winther <johnni...@google.com>
        Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
        Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
        Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
        Gerrit-CC: Paul Berry <paul...@google.com>
        Gerrit-Attention: Johnni Winther <johnni...@google.com>
        Gerrit-Attention: Konstantin Shcheglov <sche...@google.com>
        Gerrit-Comment-Date: Wed, 21 Jan 2026 15:04:00 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        open
        diffy
        Reply all
        Reply to author
        Forward
        0 new messages