Groups keyboard shortcuts have been updated
Dismiss
See shortcuts
[M] Change in dart/sdk[main]: Include or remove stray `pubspec.yaml` files.
0 views
Skip to first unread message
Lasse Nielsen (Gerrit)
Mar 6, 2025, 5:00:31 AMMar 6
to Ben Konyi, Kevin Moore, Paul Berry, Commit Queue, Alexander Markov, dart-analys...@google.com, dart-dc-te...@google.com, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Ben Konyi and Kevin Moore
Lasse Nielsen added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Lasse Nielsen . resolved
Split from https://dart-review.googlesource.com/c/sdk/+/413820, with only the pubspec.yaml changes, and a little more motivation in the message. (And not phrased as a mere "clean up", even though I do consider it cleaning up 😊).
Related details
Attention is currently required from:
- Ben Konyi
- Kevin Moore
Submit Requirements:
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lasse Nielsen (Gerrit)
Mar 6, 2025, 6:48:52 AMMar 6
to Brian Quinlan, Kevin Moore, Paul Berry, Commit Queue, Alexander Markov, dart-analys...@google.com, dart-dc-te...@google.com, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Brian Quinlan and Kevin Moore
Lasse Nielsen added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Lasse Nielsen . resolved
Replacing VM reviewer since Ben seems to be away.
Related details
Attention is currently required from:
- Brian Quinlan
- Kevin Moore
Submit Requirements:
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lasse Nielsen (Gerrit)
Mar 6, 2025, 6:50:20 AMMar 6
to Brian Quinlan, Kevin Moore, Paul Berry, Commit Queue, Alexander Markov, dart-analys...@google.com, dart-dc-te...@google.com, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Brian Quinlan and Kevin Moore
Lasse Nielsen added 1 comment![]( "Open in Gerrit")
File runtime/observatory/pubspec.yaml
Related details
Attention is currently required from:
- Brian Quinlan
- Kevin Moore
Submit Requirements:
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kevin Moore (Gerrit)
Mar 6, 2025, 11:26:04 AMMar 6
to Lasse Nielsen, Brian Quinlan, Paul Berry, Commit Queue, Alexander Markov, dart-analys...@google.com, dart-dc-te...@google.com, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Brian Quinlan and Lasse Nielsen
Kevin Moore voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Brian Quinlan
- Lasse Nielsen
Submit Requirements:
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Brian Quinlan (Gerrit)
Mar 6, 2025, 1:18:32 PMMar 6
to Lasse Nielsen, Kevin Moore, Paul Berry, Commit Queue, Alexander Markov, dart-analys...@google.com, dart-dc-te...@google.com, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Lasse Nielsen
Brian Quinlan voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Lasse Nielsen
Submit Requirements:
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lasse Nielsen (Gerrit)
Mar 14, 2025, 11:04:59 AMMar 14
to Martin Kustermann, Sigurd Meldgaard, Brian Quinlan, Kevin Moore, Paul Berry, Commit Queue, Alexander Markov, dart-analys...@google.com, dart-dc-te...@google.com, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Brian Quinlan, Kevin Moore and Martin Kustermann
Lasse Nielsen added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 6 (Latest):
Lasse Nielsen . resolved
Got run over by the workspace change, so adapting to that.
(Also made some tweaks to to the `generate_package_config.dart` script, @sig...@google.com, just more types and better RegExp.)
Related details
Attention is currently required from:
- Brian Quinlan
- Kevin Moore
- Martin Kustermann
Submit Requirements:
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lasse Nielsen (Gerrit)
Mar 14, 2025, 11:07:48 AMMar 14
to Martin Kustermann, Sigurd Meldgaard, Brian Quinlan, Kevin Moore, Paul Berry, Commit Queue, Alexander Markov, dart-analys...@google.com, dart-dc-te...@google.com, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Brian Quinlan, Kevin Moore and Martin Kustermann
Lasse Nielsen added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Lasse Nielsen (Gerrit)
Mar 14, 2025, 11:08:02 AMMar 14
to Martin Kustermann, Sigurd Meldgaard, Brian Quinlan, Kevin Moore, Paul Berry, Commit Queue, Alexander Markov, dart-analys...@google.com, dart-dc-te...@google.com, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Brian Quinlan, Kevin Moore and Martin Kustermann
Lasse Nielsen added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Lasse Nielsen . resolved
Need more +1s after rebasing. 😞
Sigurd Meldgaard (Gerrit)
Mar 14, 2025, 11:23:17 AMMar 14
to Lasse Nielsen, Martin Kustermann, Brian Quinlan, Kevin Moore, Paul Berry, Commit Queue, Alexander Markov, dart-analys...@google.com, dart-dc-te...@google.com, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Brian Quinlan, Kevin Moore, Lasse Nielsen and Martin Kustermann
Sigurd Meldgaard added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Sigurd Meldgaard . resolved
Thanks for all the clean-ups!
Had to revert the workspace cl for now (something broke in flutter)
But hopefully it can be relanded soon!
Related details
Attention is currently required from:
- Brian Quinlan
- Kevin Moore
- Lasse Nielsen
- Martin Kustermann
Submit Requirements:
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lasse Nielsen (Gerrit)
Mar 14, 2025, 11:33:49 AMMar 14
to Martin Kustermann, Sigurd Meldgaard, Brian Quinlan, Kevin Moore, Paul Berry, Commit Queue, Alexander Markov, dart-analys...@google.com, dart-dc-te...@google.com, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Brian Quinlan, Kevin Moore, Martin Kustermann and Sigurd Meldgaard
Lasse Nielsen added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Sigurd Meldgaard . resolved
Thanks for all the clean-ups!
Had to revert the workspace cl for now (something broke in flutter)
But hopefully it can be relanded soon!
Lasse Nielsen
Aha! I'll revert my changes and land my CL first! 😜
(I'll be nice and wait for the workspaces to come back. Feel free to take parts of the generate script from there if you want to.)
Related details
Attention is currently required from:
- Brian Quinlan
- Kevin Moore
- Martin Kustermann
- Sigurd Meldgaard
Submit Requirements:
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Brian Quinlan (Gerrit)
Mar 14, 2025, 11:54:13 AMMar 14
to Lasse Nielsen, Martin Kustermann, Sigurd Meldgaard, Kevin Moore, Paul Berry, Commit Queue, Alexander Markov, dart-analys...@google.com, dart-dc-te...@google.com, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Kevin Moore, Lasse Nielsen, Martin Kustermann and Sigurd Meldgaard
Brian Quinlan voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Kevin Moore
- Lasse Nielsen
- Martin Kustermann
- Sigurd Meldgaard
Submit Requirements:
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Martin Kustermann (Gerrit)
Mar 17, 2025, 4:12:15 AMMar 17
to Lasse Nielsen, Brian Quinlan, Sigurd Meldgaard, Kevin Moore, Paul Berry, Commit Queue, Alexander Markov, dart-analys...@google.com, dart-dc-te...@google.com, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Kevin Moore, Lasse Nielsen and Sigurd Meldgaard
Martin Kustermann voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Kevin Moore
- Lasse Nielsen
- Sigurd Meldgaard
Submit Requirements:
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lasse Nielsen (Gerrit)
Mar 17, 2025, 4:37:29 AMMar 17
to Martin Kustermann, Brian Quinlan, Sigurd Meldgaard, Kevin Moore, Paul Berry, Commit Queue, Alexander Markov, dart-analys...@google.com, dart-dc-te...@google.com, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Kevin Moore and Sigurd Meldgaard
Lasse Nielsen added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Lasse Nielsen . resolved
Waiting for reapplication of "Migrate ot use pub workspace". (Go Sigurd!)
Related details
Attention is currently required from:
- Kevin Moore
- Sigurd Meldgaard
Submit Requirements:
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sigurd Meldgaard (Gerrit)
Mar 31, 2025, 10:34:24 AMMar 31
to Lasse Nielsen, Martin Kustermann, Brian Quinlan, Kevin Moore, Paul Berry, Commit Queue, Alexander Markov, dart-analys...@google.com, dart-dc-te...@google.com, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Kevin Moore and Lasse Nielsen
Sigurd Meldgaard voted and added 1 comment![]( "Open in Gerrit")
Votes added by Sigurd Meldgaard
| Code-Review | +1 |
1 comment
Patchset-level comments
Sigurd Meldgaard . resolved
Thanks for this cleanup!
I have relanded the workspace CL, and it seems to be sticking.
I did not incorporate your fixes to `tools/generate_package_config.dart` So they should be able to land without merge issues.
Related details
Attention is currently required from:
- Kevin Moore
- Lasse Nielsen
Submit Requirements:
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lasse Nielsen (Gerrit)
Mar 31, 2025, 10:54:30 AMMar 31
to Sigurd Meldgaard, Martin Kustermann, Brian Quinlan, Kevin Moore, Paul Berry, Commit Queue, Alexander Markov, dart-analys...@google.com, dart-dc-te...@google.com, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Kevin Moore
Lasse Nielsen added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Sigurd Meldgaard . resolved
Thanks for this cleanup!
I have relanded the workspace CL, and it seems to be sticking.
I did not incorporate your fixes to `tools/generate_package_config.dart` So they should be able to land without merge issues.
Lasse Nielsen
Super, thanks!
Related details
Attention is currently required from:
- Kevin Moore
Submit Requirements:
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lasse Nielsen (Gerrit)
Mar 31, 2025, 10:54:31 AMMar 31
to Sigurd Meldgaard, Martin Kustermann, Brian Quinlan, Kevin Moore, Paul Berry, Commit Queue, Alexander Markov, dart-analys...@google.com, dart-dc-te...@google.com, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Kevin Moore
Lasse Nielsen voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Commit Queue (Gerrit)
Mar 31, 2025, 11:30:38 AMMar 31
to Lasse Nielsen, Sigurd Meldgaard, Martin Kustermann, Brian Quinlan, Kevin Moore, Paul Berry, Alexander Markov, dart-analys...@google.com, dart-dc-te...@google.com, rev...@dartlang.org, vm-...@dartlang.org
Commit Queue submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Include or remove stray `pubspec.yaml` files.
There were `pubspec.yaml` files in `tools/` that were not
included in the global package config.
That means that their imports were irrelevant, which could
be misleading. And if any tool would look at the
`pubspec.yaml` file, it might be inconsistent with
the actual package resolution.
Makes every `pubspec.yaml` file either be included by the
`tools/generate_package_config.dart` script, or deletes them
if they seem to be stale and unused.
(Compare vs. `git ls-files '**/pubspec.yaml'`.)
Excepted `tools/dart2js/sourceMapViewer/pubspec.yaml`.
The entire directory might be stale. The dependencies of
that pubspec are not SDK dependencies otherwise,
the pubspec has no SDK min-version, which is now a requirement,
and the README refers to a *packages directory*.
Keeping as-is and filing issue to have owners take a look.
Added `lib/` directory to `tools/` to avoid `tools/bots/`
being inside the package URI root of the `tools/` package,
which would cause its `../../pkg/...` import to fail.
Makes every `pubspec.yaml` file use a `^...` SDK constraint instead
of the longer `>= ... < ...` format.
Tested: No new tests, goal is to keep running the same way
Change-Id: I688e463fe985fc4de43550a1f4c7ff350536cffc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/414020
Commit-Queue: Lasse Nielsen <l...@google.com>
Reviewed-by: Martin Kustermann <kuste...@google.com>
Reviewed-by: Sigurd Meldgaard <sig...@google.com>
Reviewed-by: Brian Quinlan <bqui...@google.com>
Files:
- M pkg/dev_compiler/pubspec.yaml
- M pkg/reload_test/pubspec.yaml
- M pkg/vm/pubspec.yaml
- M pubspec.yaml
- M runtime/observatory/pubspec.yaml
- M runtime/observatory/tests/service/observatory_test_package/pubspec.yaml
- M runtime/tools/profiling/pubspec.yaml
- M tools/bisect.dart
- M tools/generate_package_config.dart
- A tools/lib/README.md
- M tools/verify_docs/bin/verify_docs.dart
- M tools/verify_docs/pubspec.yaml
Change size: M
Delta: 12 files changed, 78 insertions(+), 60 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Martin Kustermann, +1 by Sigurd Meldgaard, +1 by Brian Quinlan
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages