[M] Change in dart/sdk[main]: Make nameOffset name more precise on Directives and remove -2 suffix ...

0 views
Skip to first unread message

Konstantin Shcheglov (Gerrit)

unread,
Aug 7, 2025, 7:09:24 PM8/7/25
to Fedor Shcheglov, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Fedor Shcheglov

Konstantin Shcheglov voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Fedor Shcheglov
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I5832c7340726ba82ea1e3bac5c88441fd318a2f2
Gerrit-Change-Number: 444391
Gerrit-PatchSet: 2
Gerrit-Owner: Fedor Shcheglov <fedor.s...@gmail.com>
Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
Gerrit-Attention: Fedor Shcheglov <fedor.s...@gmail.com>
Gerrit-Comment-Date: Thu, 07 Aug 2025 23:09:22 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Johnni Winther (Gerrit)

unread,
Aug 8, 2025, 2:47:08 AM8/8/25
to Fedor Shcheglov, Paul Berry, Commit Queue, Konstantin Shcheglov, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Fedor Shcheglov and Paul Berry

Johnni Winther voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Fedor Shcheglov
  • Paul Berry
Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: I5832c7340726ba82ea1e3bac5c88441fd318a2f2
    Gerrit-Change-Number: 444391
    Gerrit-PatchSet: 2
    Gerrit-Owner: Fedor Shcheglov <fedor.s...@gmail.com>
    Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
    Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
    Gerrit-Reviewer: Paul Berry <paul...@google.com>
    Gerrit-Attention: Fedor Shcheglov <fedor.s...@gmail.com>
    Gerrit-Attention: Paul Berry <paul...@google.com>
    Gerrit-Comment-Date: Fri, 08 Aug 2025 06:47:02 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Konstantin Shcheglov (Gerrit)

    unread,
    Aug 8, 2025, 12:15:48 PM8/8/25
    to Fedor Shcheglov, Johnni Winther, Paul Berry, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
    Attention needed from Fedor Shcheglov and Paul Berry

    Konstantin Shcheglov voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Fedor Shcheglov
    • Paul Berry
    Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: I5832c7340726ba82ea1e3bac5c88441fd318a2f2
    Gerrit-Change-Number: 444391
    Gerrit-PatchSet: 2
    Gerrit-Owner: Fedor Shcheglov <fedor.s...@gmail.com>
    Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
    Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
    Gerrit-Reviewer: Paul Berry <paul...@google.com>
    Gerrit-Attention: Fedor Shcheglov <fedor.s...@gmail.com>
    Gerrit-Attention: Paul Berry <paul...@google.com>
    Gerrit-Comment-Date: Fri, 08 Aug 2025 16:15:45 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Commit Queue (Gerrit)

    unread,
    Aug 8, 2025, 12:16:07 PM8/8/25
    to Fedor Shcheglov, Johnni Winther, Paul Berry, Konstantin Shcheglov, dart-analys...@google.com, rev...@dartlang.org

    Commit Queue submitted the change

    Change information

    Commit message:
    Make nameOffset name more precise on Directives and remove -2 suffix from other nameOffset fields.
    Change-Id: I5832c7340726ba82ea1e3bac5c88441fd318a2f2
    Reviewed-by: Konstantin Shcheglov <sche...@google.com>
    Reviewed-by: Johnni Winther <johnni...@google.com>
    Commit-Queue: Konstantin Shcheglov <sche...@google.com>
    Files:
    • M pkg/analyzer/lib/src/dart/analysis/driver.dart
    • M pkg/analyzer/lib/src/summary2/informative_data.dart
    • M pkg/analyzer/test/src/summary/elements/library_import_test.dart
    Change size: M
    Delta: 3 files changed, 84 insertions(+), 89 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Johnni Winther, +1 by Konstantin Shcheglov
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: I5832c7340726ba82ea1e3bac5c88441fd318a2f2
    Gerrit-Change-Number: 444391
    Gerrit-PatchSet: 3
    Gerrit-Owner: Fedor Shcheglov <fedor.s...@gmail.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages