[XS] Change in dart/sdk[main]: [vm, profiler] Don't attempt a Dart stack walk during FFI leaf calls.

0 views
Skip to first unread message

Ryan Macnak (Gerrit)

unread,
Mar 25, 2026, 9:09:14 PM (5 days ago) Mar 25
to Alexander Aprelev, Commit Queue, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Alexander Aprelev

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Alexander Aprelev
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedCommit-Message-Has-TEST
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I42bb6c8c9dd08c3ee004f10befffe3e484189147
Gerrit-Change-Number: 490780
Gerrit-PatchSet: 3
Gerrit-Owner: Ryan Macnak <rma...@google.com>
Gerrit-Reviewer: Alexander Aprelev <a...@google.com>
Gerrit-Reviewer: Ryan Macnak <rma...@google.com>
Gerrit-Attention: Alexander Aprelev <a...@google.com>
Gerrit-Comment-Date: Thu, 26 Mar 2026 01:09:11 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Alexander Aprelev (Gerrit)

unread,
Mar 25, 2026, 10:58:31 PM (5 days ago) Mar 25
to Ryan Macnak, Alexander Aprelev, Commit Queue, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Ryan Macnak

Alexander Aprelev voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Ryan Macnak
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedCommit-Message-Has-TEST
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I42bb6c8c9dd08c3ee004f10befffe3e484189147
Gerrit-Change-Number: 490780
Gerrit-PatchSet: 3
Gerrit-Owner: Ryan Macnak <rma...@google.com>
Gerrit-Reviewer: Alexander Aprelev <a...@google.com>
Gerrit-Reviewer: Ryan Macnak <rma...@google.com>
Gerrit-Attention: Ryan Macnak <rma...@google.com>
Gerrit-Comment-Date: Thu, 26 Mar 2026 02:58:27 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Ryan Macnak (Gerrit)

unread,
12:31 PM (8 hours ago) 12:31 PM
to Alexander Aprelev, Commit Queue, rev...@dartlang.org, vm-...@dartlang.org

Ryan Macnak voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedCommit-Message-Has-TEST
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: I42bb6c8c9dd08c3ee004f10befffe3e484189147
    Gerrit-Change-Number: 490780
    Gerrit-PatchSet: 4
    Gerrit-Owner: Ryan Macnak <rma...@google.com>
    Gerrit-Reviewer: Alexander Aprelev <a...@google.com>
    Gerrit-Reviewer: Ryan Macnak <rma...@google.com>
    Gerrit-Comment-Date: Mon, 30 Mar 2026 16:30:59 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Commit Queue (Gerrit)

    unread,
    1:13 PM (7 hours ago) 1:13 PM
    to Ryan Macnak, Alexander Aprelev, rev...@dartlang.org, vm-...@dartlang.org

    Commit Queue submitted the change

    Unreviewed changes

    3 is the latest approved patch-set.
    No files were changed between the latest approved patch-set and the submitted one.

    Change information

    Commit message:
    [vm, profiler] Don't attempt a Dart stack walk during FFI leaf calls.

    TEST=ci
    Bug: https://github.com/dart-lang/sdk/issues/62932
    Change-Id: I42bb6c8c9dd08c3ee004f10befffe3e484189147
    Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/490780
    Commit-Queue: Ryan Macnak <rma...@google.com>
    Reviewed-by: Alexander Aprelev <a...@google.com>
    Files:
    • M runtime/vm/profiler.cc
    Change size: XS
    Delta: 1 file changed, 4 insertions(+), 1 deletion(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Alexander Aprelev
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: I42bb6c8c9dd08c3ee004f10befffe3e484189147
    Gerrit-Change-Number: 490780
    Gerrit-PatchSet: 5
    Gerrit-Owner: Ryan Macnak <rma...@google.com>
    Gerrit-Reviewer: Alexander Aprelev <a...@google.com>
    Gerrit-Reviewer: Ryan Macnak <rma...@google.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages