[S] Change in dart/sdk[main]: [dart2wasm] compile_benchmark: always run wasm-opt when optimizations...
0 views
Skip to first unread message
Ömer Ağacan (Gerrit)
Dec 22, 2025, 6:45:23 AM (3 days ago) Dec 22
to Nate Biggs, Martin Kustermann, Commit Queue, dart2wasm-t...@google.com, rev...@dartlang.org
Attention needed from Martin Kustermann and Nate Biggs
Ömer Ağacan voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Martin Kustermann
- Nate Biggs
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nate Biggs (Gerrit)
Dec 22, 2025, 11:21:55 AM (2 days ago) Dec 22
to Ömer Ağacan, Martin Kustermann, Commit Queue, dart2wasm-t...@google.com, rev...@dartlang.org
Attention needed from Martin Kustermann and Ömer Ağacan
Nate Biggs added 1 comment![]( "Open in Gerrit")
File pkg/dart2wasm/tool/compile_benchmark
Line 104, Patchset 3 (Latest):
# `--optimization-level`.Nate Biggs . unresolved
Dart2wasm does support `--optimization-level`: https://github.com/dart-lang/sdk/blob/main/pkg/dart2wasm/lib/dart2wasm.dart#L22
The issue is just with the handling of `-O0` above. We should be able to combine this with the above case to:
```
-O* | --optimization-level=*)
DART2WASM_ARGS+=("$1")
if [ "${1#-O}" == "0" ] || [ "${1#--optimization-level=}" == "0" ]; then
RUN_BINARYEN=0
else
RUN_BINARYEN=1
fi
shift
;;
```
I tested this locally and it does fix the issue with binaryen not running.
Related details
Attention is currently required from:
- Martin Kustermann
- Ömer Ağacan
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ömer Ağacan (Gerrit)
Dec 23, 2025, 4:21:43 AM (yesterday) Dec 23
to Nate Biggs, Martin Kustermann, Commit Queue, dart2wasm-t...@google.com, rev...@dartlang.org
Attention needed from Martin Kustermann and Nate Biggs
Ömer Ağacan added 1 comment![]( "Open in Gerrit")
File pkg/dart2wasm/tool/compile_benchmark
Dart2wasm does support `--optimization-level`: https://github.com/dart-lang/sdk/blob/main/pkg/dart2wasm/lib/dart2wasm.dart#L22
The issue is just with the handling of `-O0` above. We should be able to combine this with the above case to:
```
-O* | --optimization-level=*)
DART2WASM_ARGS+=("$1")
if [ "${1#-O}" == "0" ] || [ "${1#--optimization-level=}" == "0" ]; then
RUN_BINARYEN=0
else
RUN_BINARYEN=1
fi
shift
;;
```I tested this locally and it does fix the issue with binaryen not running.
Attention is currently required from:
- Martin Kustermann
- Nate Biggs
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nate Biggs (Gerrit)
Dec 23, 2025, 10:55:03 AM (yesterday) Dec 23
to Ömer Ağacan, Martin Kustermann, Commit Queue, dart2wasm-t...@google.com, rev...@dartlang.org
Attention needed from Martin Kustermann and Ömer Ağacan
Nate Biggs voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Martin Kustermann
- Ömer Ağacan
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ömer Ağacan (Gerrit)
Dec 23, 2025, 11:04:33 AM (yesterday) Dec 23
to Nate Biggs, Martin Kustermann, Commit Queue, dart2wasm-t...@google.com, rev...@dartlang.org
Attention needed from Martin Kustermann
Ömer Ağacan voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Martin Kustermann
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Commit Queue (Gerrit)
Dec 23, 2025, 11:32:37 AM (yesterday) Dec 23
to Ömer Ağacan, Nate Biggs, Martin Kustermann, dart2wasm-t...@google.com, rev...@dartlang.org
Commit Queue submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[dart2wasm] compile_benchmark: always run wasm-opt when optimizations are enabled
Currently if I pass `compile_benchmark ... -O0 ... -O4 ...`, the first
`-O` disables wasm-opt, but the second `-O` doesn't enable it again.
With this CL the last `-O` decides whether to run wasm-opt.
Change-Id: I0f41a833f45a25a00c59da0e7e2a3c087b8dd666
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/469460
Reviewed-by: Nate Biggs <nate...@google.com>
Commit-Queue: Ömer Ağacan <ome...@google.com>
Files:
- M pkg/dart2wasm/tool/compile_benchmark
Change size: XS
Delta: 1 file changed, 6 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Nate Biggs
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages