[M] Change in dart/sdk[main]: CQ. Use stored FormalParameterElementImpl.isCovariant instead of inhe...

[Johnni Winther (Gerrit)]

Attention needed from Konstantin Shcheglov and Paul Berry

Johnni Winther voted and added 1 comment

Votes added by Johnni Winther

Code-Review

+1

1 comment

File pkg/analyzer/lib/src/summary2/instance_member_inferrer.dart

Line 523, Patchset 2 (Latest): for (var o in overridden) {
var param = _getCorrespondingParameter(

Johnni Winther . unresolved

Could we stop early if the `parameter` is already covariant?

Open in Gerrit

Related details

Attention is currently required from:

• Konstantin Shcheglov
• Paul Berry

Submit Requirements:

• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: sdk

Gerrit-Branch: main

Gerrit-Change-Id: I33064d556fc17bfa78dc2b9a5672298b271c193c

Gerrit-Change-Number: 516442

Gerrit-PatchSet: 2

Gerrit-Owner: Konstantin Shcheglov <sche...@google.com>

Gerrit-Reviewer: Johnni Winther <johnni...@google.com>

Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>

Gerrit-Reviewer: Paul Berry <paul...@google.com>

Gerrit-CC: dart-...@luci-project-accounts.iam.gserviceaccount.com <dart-...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Paul Berry <paul...@google.com>

Gerrit-Attention: Konstantin Shcheglov <sche...@google.com>

Gerrit-Comment-Date: Wed, 24 Jun 2026 07:55:38 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes