[M] Change in dart/sdk[main]: linter: Use an extension type's representation type when calculating ...
0 views
Skip to first unread message
Samuel Rawlins (Gerrit)
May 12, 2026, 4:59:08 PM (17 hours ago) May 12
to Brian Wilkerson, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Brian Wilkerson
Samuel Rawlins voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Brian Wilkerson
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Brian Wilkerson (Gerrit)
May 12, 2026, 5:26:13 PM (17 hours ago) May 12
to Samuel Rawlins, Brian Wilkerson, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Samuel Rawlins
Brian Wilkerson voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Samuel Rawlins
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Samuel Rawlins (Gerrit)
May 12, 2026, 5:27:50 PM (17 hours ago) May 12
to Brian Wilkerson, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-analys...@google.com, rev...@dartlang.org
Samuel Rawlins voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
May 12, 2026, 5:27:59 PM (17 hours ago) May 12
to Samuel Rawlins, Brian Wilkerson, dart-analys...@google.com, rev...@dartlang.org
dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Change information
Commit message:
linter: Use an extension type's representation type when calculating unrelated types
Fixes https://github.com/dart-lang/sdk/issues/58838
Fixes https://github.com/dart-lang/sdk/issues/59373
Fixes https://github.com/dart-lang/sdk/issues/59299
The change is based entirely on runtime behavior. We just use the
"extension type erasure." So two instances of two extension types are
related if the representation types of those extension types are
related.
Change-Id: I3c40e072433608146f00194359c3c312b319c913
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/503120
Reviewed-by: Brian Wilkerson <brianwi...@google.com>
Commit-Queue: Samuel Rawlins <sraw...@google.com>
Files:
- M pkg/linter/lib/src/util/dart_type_utilities.dart
- M pkg/linter/test/rules/collection_methods_unrelated_type_test.dart
- M pkg/linter/test/rules/unrelated_type_equality_checks_test.dart
Change size: M
Delta: 3 files changed, 78 insertions(+), 24 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Brian Wilkerson
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages