Martin Kustermann (Gerrit)

unread,

Oct 30, 2025, 7:13:33 PM (2 days ago) Oct 30

to Nate Biggs, Commit Queue, rev...@dartlang.org

Attention needed from Martin Kustermann and Nate Biggs

Martin Kustermann voted Commit-Queue+1

Commit-Queue

+1

Open in Gerrit

Related details

Attention is currently required from:

Martin Kustermann
Nate Biggs

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Nate Biggs (Gerrit)

unread,

Oct 30, 2025, 7:24:30 PM (2 days ago) Oct 30

to Martin Kustermann, Commit Queue, rev...@dartlang.org

Attention needed from Martin Kustermann

Nate Biggs voted and added 1 comment

Votes added by Nate Biggs

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Nate Biggs . resolved

Nice!

Open in Gerrit

Related details

Attention is currently required from:

Martin Kustermann

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Martin Kustermann (Gerrit)

unread,

Oct 31, 2025, 3:57:01 AM (21 hours ago) Oct 31

to Nate Biggs, Commit Queue, rev...@dartlang.org

Martin Kustermann voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Commit Queue (Gerrit)

unread,

Oct 31, 2025, 4:23:03 AM (20 hours ago) Oct 31

to Martin Kustermann, Nate Biggs, rev...@dartlang.org

Commit Queue submitted the change

Change information

Commit message:

[dart2wasm] Also use --traps-never-happen in deferred loading mode

The dar2wasm compiler - when used in -O2 sound mode - should guarantee
that no wasm traps happen. So we should  be able to use
`--traps-never-happen` in deferred loading mode just like in normal
mode.

This saves around 1.2% in ACX Gallery

Change-Id: I3d214b636b0bc2e8b18c2ef8c4bf0c86b19c23c8

Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/458720

Commit-Queue: Martin Kustermann <kuste...@google.com>

Reviewed-by: Nate Biggs <nate...@google.com>

Files:

M pkg/dartdev/lib/src/commands/compile.dart

Change size: XS

Delta: 1 file changed, 1 insertion(+), 0 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Nate Biggs

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Paul Berry (Gerrit)

unread,

Oct 31, 2025, 9:30:25 AM (15 hours ago) Oct 31

to Martin Kustermann, Commit Queue, Nate Biggs, rev...@dartlang.org

Paul Berry added 1 comment

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Paul Berry . resolved

This seems to have broken the test `pkg/dart2wasm/test/ir_test`. See https://ci.chromium.org/ui/p/dart/builders/ci.sandbox/dart2wasm-asserts-linux-chrome/2901/overview.

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Martin Kustermann (Gerrit)

unread,

Oct 31, 2025, 9:34:06 AM (15 hours ago) Oct 31

to Commit Queue, Paul Berry, Nate Biggs, rev...@dartlang.org

Martin Kustermann added 1 comment

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Paul Berry . resolved

This seems to have broken the test `pkg/dart2wasm/test/ir_test`. See https://ci.chromium.org/ui/p/dart/builders/ci.sandbox/dart2wasm-asserts-linux-chrome/2901/overview.

Martin Kustermann

Yeah, the CQ didn't run the tests it's supposed to. I think it will get fixed by another CL: https://dart-review.googlesource.com/c/sdk/+/458840/3

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Paul Berry (Gerrit)

unread,

Oct 31, 2025, 10:54:29 AM (14 hours ago) Oct 31

to Martin Kustermann, Commit Queue, Nate Biggs, rev...@dartlang.org

Paul Berry added 1 comment

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Paul Berry . resolved

This seems to have broken the test `pkg/dart2wasm/test/ir_test`. See https://ci.chromium.org/ui/p/dart/builders/ci.sandbox/dart2wasm-asserts-linux-chrome/2901/overview.

Martin Kustermann

Yeah, the CQ didn't run the tests it's supposed to. I think it will get fixed by another CL: https://dart-review.googlesource.com/c/sdk/+/458840/3

Paul Berry

Ok, thanks! I've gone ahead and created a revert just in case we need that as a backup plan: https://dart-review.googlesource.com/c/sdk/+/458900

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Paul Berry (Gerrit)

unread,

Oct 31, 2025, 2:20:04 PM (10 hours ago) Oct 31

to Martin Kustermann, Commit Queue, Nate Biggs, rev...@dartlang.org

Paul Berry added 1 comment

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Paul Berry . resolved

This seems to have broken the test `pkg/dart2wasm/test/ir_test`. See https://ci.chromium.org/ui/p/dart/builders/ci.sandbox/dart2wasm-asserts-linux-chrome/2901/overview.

Martin Kustermann

Yeah, the CQ didn't run the tests it's supposed to. I think it will get fixed by another CL: https://dart-review.googlesource.com/c/sdk/+/458840/3

Paul Berry

Ok, thanks! I've gone ahead and created a revert just in case we need that as a backup plan: https://dart-review.googlesource.com/c/sdk/+/458900

Paul Berry

It's past 7pm in Aarhus. There's been no activity on https://dart-review.googlesource.com/c/sdk/+/458840 for several hours, and it still has unresolved comments. So I'm going to move forward with the revert in order to unblock my work for the day.

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Paul Berry (Gerrit)

unread,

Oct 31, 2025, 2:21:08 PM (10 hours ago) Oct 31

to Martin Kustermann, Commit Queue, Nate Biggs, rev...@dartlang.org

Paul Berry has created a revert of this change

Open original change

Related details

Attention set is empty

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Reply all

Reply to author

Forward

[XS] Change in dart/sdk[main]: [dart2wasm] Also use --traps-never-happen in deferred loading mode

Martin Kustermann (Gerrit)

Martin Kustermann voted Commit-Queue+1

Related details

Nate Biggs (Gerrit)

Nate Biggs voted and added 1 comment

Votes added by Nate Biggs

1 comment

Related details

Martin Kustermann (Gerrit)

Martin Kustermann voted Commit-Queue+2

Related details

Commit Queue (Gerrit)

Commit Queue submitted the change

Change information

Paul Berry (Gerrit)

Paul Berry added 1 comment

Related details

Martin Kustermann (Gerrit)

Martin Kustermann added 1 comment

Related details

Paul Berry (Gerrit)

Paul Berry added 1 comment

Related details

Paul Berry (Gerrit)

Paul Berry added 1 comment

Related details

Paul Berry (Gerrit)

Paul Berry has created a revert of this change

Related details