[L] Change in dart/sdk[main]: Update the addMissingParameterNamed fix for primary constructors
0 views
Skip to first unread message
Brian Wilkerson (Gerrit)
Mar 13, 2026, 5:27:50 PMMar 13
to Brian Wilkerson, Samuel Rawlins, Konstantin Shcheglov, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Konstantin Shcheglov and Samuel Rawlins
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Konstantin Shcheglov
- Samuel Rawlins
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Konstantin Shcheglov (Gerrit)
Mar 13, 2026, 5:36:12 PMMar 13
to Brian Wilkerson, Samuel Rawlins, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Brian Wilkerson and Samuel Rawlins
Konstantin Shcheglov voted and added 1 comment![]( "Open in Gerrit")
Votes added by Konstantin Shcheglov
| Code-Review | +1 |
1 comment
File pkg/analyzer/lib/src/dart/analysis/results.dart
Line 104, Patchset 2 (Latest):
} else if ((fragment.element as ConstructorElementImpl).isPrimary) {Konstantin Shcheglov . unresolved
Would be nice to have a test for this block.
We don't have a lot of tests, but here is one: `test_getParsedLibrary_getElementDeclaration_class`
Related details
Attention is currently required from:
- Brian Wilkerson
- Samuel Rawlins
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Samuel Rawlins (Gerrit)
Mar 13, 2026, 5:38:03 PMMar 13
to Brian Wilkerson, Konstantin Shcheglov, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Brian Wilkerson
Samuel Rawlins voted and added 1 comment![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Brian Wilkerson
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Brian Wilkerson (Gerrit)
Mar 16, 2026, 11:59:01 AMMar 16
to Brian Wilkerson, Samuel Rawlins, Konstantin Shcheglov, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Konstantin Shcheglov and Samuel Rawlins
Brian Wilkerson voted and added 2 comments![]( "Open in Gerrit")
Votes added by Brian Wilkerson
| Commit-Queue | +1 |
2 comments
Patchset-level comments
File pkg/analyzer/lib/src/dart/analysis/results.dart
Line 104, Patchset 2:
} else if ((fragment.element as ConstructorElementImpl).isPrimary) {Konstantin Shcheglov . resolved
Would be nice to have a test for this block.
We don't have a lot of tests, but here is one: `test_getParsedLibrary_getElementDeclaration_class`
Attention is currently required from:
- Konstantin Shcheglov
- Samuel Rawlins
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Samuel Rawlins (Gerrit)
Mar 16, 2026, 11:59:23 AMMar 16
to Brian Wilkerson, Konstantin Shcheglov, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Brian Wilkerson and Konstantin Shcheglov
Samuel Rawlins voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Brian Wilkerson
- Konstantin Shcheglov
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Konstantin Shcheglov (Gerrit)
Mar 16, 2026, 2:14:14 PMMar 16
to Brian Wilkerson, Samuel Rawlins, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Brian Wilkerson
Konstantin Shcheglov voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Brian Wilkerson
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Brian Wilkerson (Gerrit)
Mar 16, 2026, 2:27:54 PMMar 16
to Brian Wilkerson, Konstantin Shcheglov, Samuel Rawlins, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Brian Wilkerson voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Commit Queue (Gerrit)
Mar 16, 2026, 2:28:04 PMMar 16
to Brian Wilkerson, Konstantin Shcheglov, Samuel Rawlins, dart-analys...@google.com, rev...@dartlang.org
Commit Queue submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Update the addMissingParameterNamed fix for primary constructors
This required updating some utility methods used by the fix. I'm not
sure what other code that effects.
Change-Id: If0c1df36847d4a319624252f63901af18c7fafe4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/487640
Reviewed-by: Konstantin Shcheglov <sche...@google.com>
Commit-Queue: Brian Wilkerson <brianwi...@google.com>
Reviewed-by: Samuel Rawlins <sraw...@google.com>
Files:
- M pkg/analysis_server/lib/src/services/correction/dart/add_missing_parameter_named.dart
- M pkg/analysis_server/lib/src/services/correction/executable_parameters.dart
- M pkg/analysis_server/test/src/services/correction/fix/add_missing_parameter_named_test.dart
- M pkg/analyzer/lib/src/dart/analysis/results.dart
- M pkg/analyzer/test/src/dart/analysis/session_test.dart
Change size: L
Delta: 5 files changed, 555 insertions(+), 19 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Konstantin Shcheglov, +1 by Samuel Rawlins
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages