[S] Change in dart/sdk[main]: [analyzer] Avoid _SlowSetRange in Scanner.tokenize

0 views
Skip to first unread message

Johnni Winther (Gerrit)

unread,
Jun 2, 2026, 7:30:33 AM (yesterday) Jun 2
to Jens Johansen, dart-...@luci-project-accounts.iam.gserviceaccount.com, Paul Berry, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Jens Johansen

Johnni Winther voted and added 1 comment

Votes added by Johnni Winther

Code-Review+1

1 comment

File pkg/_fe_analyzer_shared/lib/src/scanner/abstract_scanner.dart
Line 2485, Patchset 2 (Latest): List<int> copyToTypeDataWithoutLastElement() {
Johnni Winther . unresolved

Should it be `copyToTypedDataWithoutLastElement`?

Open in Gerrit

Related details

Attention is currently required from:
  • Jens Johansen
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Ibf6c7f6cc9324a54d2bd99c37058103af106164c
Gerrit-Change-Number: 508580
Gerrit-PatchSet: 2
Gerrit-Owner: Jens Johansen <je...@google.com>
Gerrit-Reviewer: Jens Johansen <je...@google.com>
Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
Gerrit-CC: Paul Berry <paul...@google.com>
Gerrit-Attention: Jens Johansen <je...@google.com>
Gerrit-Comment-Date: Tue, 02 Jun 2026 11:30:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Jens Johansen (Gerrit)

unread,
Jun 2, 2026, 7:34:43 AM (yesterday) Jun 2
to Johnni Winther, dart-...@luci-project-accounts.iam.gserviceaccount.com, Paul Berry, dart-analys...@google.com, rev...@dartlang.org

Jens Johansen voted and added 1 comment

Votes added by Jens Johansen

Commit-Queue+1

1 comment

File pkg/_fe_analyzer_shared/lib/src/scanner/abstract_scanner.dart
Line 2485, Patchset 2: List<int> copyToTypeDataWithoutLastElement() {
Johnni Winther . resolved

Should it be `copyToTypedDataWithoutLastElement`?

Jens Johansen

Yes.

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Ibf6c7f6cc9324a54d2bd99c37058103af106164c
Gerrit-Change-Number: 508580
Gerrit-PatchSet: 3
Gerrit-Owner: Jens Johansen <je...@google.com>
Gerrit-Reviewer: Jens Johansen <je...@google.com>
Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
Gerrit-CC: Paul Berry <paul...@google.com>
Gerrit-Comment-Date: Tue, 02 Jun 2026 11:34:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Johnni Winther <johnni...@google.com>
satisfied_requirement
open
diffy

Jens Johansen (Gerrit)

unread,
9:54 AM (8 hours ago) 9:54 AM
to Johnni Winther, dart-...@luci-project-accounts.iam.gserviceaccount.com, Paul Berry, dart-analys...@google.com, rev...@dartlang.org

Jens Johansen voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Ibf6c7f6cc9324a54d2bd99c37058103af106164c
Gerrit-Change-Number: 508580
Gerrit-PatchSet: 3
Gerrit-Owner: Jens Johansen <je...@google.com>
Gerrit-Reviewer: Jens Johansen <je...@google.com>
Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
Gerrit-CC: Paul Berry <paul...@google.com>
Gerrit-Comment-Date: Wed, 03 Jun 2026 13:53:56 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages