[XL] Change in dart/sdk[main]: [cfe][PrimaryConstructors] Use MemberLookupResult for redirecting ini...

0 views
Skip to first unread message

Chloe Stefantsova (Gerrit)

unread,
Mar 9, 2026, 5:40:44 AM (20 hours ago) Mar 9
to Johnni Winther, Chloe Stefantsova, Commit Queue, Paul Berry, dart-analys...@google.com, dart-fe-te...@google.com, rev...@dartlang.org
Attention needed from Johnni Winther

Chloe Stefantsova voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Johnni Winther
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I465747883af594870cb0663e80a188e6dd1b552b
Gerrit-Change-Number: 486202
Gerrit-PatchSet: 2
Gerrit-Owner: Johnni Winther <johnni...@google.com>
Gerrit-Reviewer: Chloe Stefantsova <cstefa...@google.com>
Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
Gerrit-CC: Paul Berry <paul...@google.com>
Gerrit-Attention: Johnni Winther <johnni...@google.com>
Gerrit-Comment-Date: Mon, 09 Mar 2026 09:40:39 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
unsatisfied_requirement
satisfied_requirement
open
diffy

Chloe Stefantsova (Gerrit)

unread,
Mar 9, 2026, 5:45:22 AM (20 hours ago) Mar 9
to Johnni Winther, Chloe Stefantsova, Commit Queue, Paul Berry, dart-analys...@google.com, dart-fe-te...@google.com, rev...@dartlang.org
Attention needed from Johnni Winther

Chloe Stefantsova voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Johnni Winther
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I465747883af594870cb0663e80a188e6dd1b552b
Gerrit-Change-Number: 486202
Gerrit-PatchSet: 3
Gerrit-Owner: Johnni Winther <johnni...@google.com>
Gerrit-Reviewer: Chloe Stefantsova <cstefa...@google.com>
Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
Gerrit-CC: Paul Berry <paul...@google.com>
Gerrit-Attention: Johnni Winther <johnni...@google.com>
Gerrit-Comment-Date: Mon, 09 Mar 2026 09:45:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
unsatisfied_requirement
satisfied_requirement
open
diffy

Johnni Winther (Gerrit)

unread,
Mar 9, 2026, 6:04:38 AM (19 hours ago) Mar 9
to Erik Ernst, Chloe Stefantsova, Commit Queue, Paul Berry, dart-analys...@google.com, dart-fe-te...@google.com, rev...@dartlang.org
Attention needed from Erik Ernst and Johnni Winther

Johnni Winther voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Erik Ernst
  • Johnni Winther
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I465747883af594870cb0663e80a188e6dd1b552b
Gerrit-Change-Number: 486202
Gerrit-PatchSet: 3
Gerrit-Owner: Johnni Winther <johnni...@google.com>
Gerrit-Reviewer: Chloe Stefantsova <cstefa...@google.com>
Gerrit-Reviewer: Erik Ernst <eer...@google.com>
Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
Gerrit-CC: Paul Berry <paul...@google.com>
Gerrit-Attention: Erik Ernst <eer...@google.com>
Gerrit-Attention: Johnni Winther <johnni...@google.com>
Gerrit-Comment-Date: Mon, 09 Mar 2026 10:04:32 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
unsatisfied_requirement
satisfied_requirement
open
diffy

Erik Ernst (Gerrit)

unread,
Mar 9, 2026, 6:37:24 AM (19 hours ago) Mar 9
to Johnni Winther, Chloe Stefantsova, Commit Queue, Paul Berry, dart-analys...@google.com, dart-fe-te...@google.com, rev...@dartlang.org
Attention needed from Johnni Winther

Erik Ernst voted and added 1 comment

Votes added by Erik Ernst

Code-Review+1

1 comment

Patchset-level comments
Open in Gerrit

Related details

Attention is currently required from:
  • Johnni Winther
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I465747883af594870cb0663e80a188e6dd1b552b
Gerrit-Change-Number: 486202
Gerrit-PatchSet: 3
Gerrit-Owner: Johnni Winther <johnni...@google.com>
Gerrit-Reviewer: Chloe Stefantsova <cstefa...@google.com>
Gerrit-Reviewer: Erik Ernst <eer...@google.com>
Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
Gerrit-CC: Paul Berry <paul...@google.com>
Gerrit-Attention: Johnni Winther <johnni...@google.com>
Gerrit-Comment-Date: Mon, 09 Mar 2026 10:37:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Johnni Winther (Gerrit)

unread,
Mar 9, 2026, 7:19:39 AM (18 hours ago) Mar 9
to Erik Ernst, Chloe Stefantsova, Commit Queue, Paul Berry, dart-analys...@google.com, dart-fe-te...@google.com, rev...@dartlang.org

Johnni Winther voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I465747883af594870cb0663e80a188e6dd1b552b
Gerrit-Change-Number: 486202
Gerrit-PatchSet: 4
Gerrit-Owner: Johnni Winther <johnni...@google.com>
Gerrit-Reviewer: Chloe Stefantsova <cstefa...@google.com>
Gerrit-Reviewer: Erik Ernst <eer...@google.com>
Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
Gerrit-CC: Paul Berry <paul...@google.com>
Gerrit-Comment-Date: Mon, 09 Mar 2026 11:19:34 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Johnni Winther (Gerrit)

unread,
Mar 9, 2026, 8:12:28 AM (17 hours ago) Mar 9
to Erik Ernst, Chloe Stefantsova, Commit Queue, Paul Berry, dart-analys...@google.com, dart-fe-te...@google.com, rev...@dartlang.org
Gerrit-Comment-Date: Mon, 09 Mar 2026 12:12:24 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Johnni Winther (Gerrit)

unread,
Mar 9, 2026, 4:32:15 PM (9 hours ago) Mar 9
to Erik Ernst, Chloe Stefantsova, Commit Queue, Paul Berry, dart-analys...@google.com, dart-fe-te...@google.com, rev...@dartlang.org
Attention needed from Chloe Stefantsova and Erik Ernst

Johnni Winther added 1 comment

Patchset-level comments
File-level comment, Patchset 5 (Latest):
Johnni Winther . resolved

I need some new +1's.

Open in Gerrit

Related details

Attention is currently required from:
  • Chloe Stefantsova
  • Erik Ernst
Submit Requirements:
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: I465747883af594870cb0663e80a188e6dd1b552b
    Gerrit-Change-Number: 486202
    Gerrit-PatchSet: 5
    Gerrit-Owner: Johnni Winther <johnni...@google.com>
    Gerrit-Reviewer: Chloe Stefantsova <cstefa...@google.com>
    Gerrit-Reviewer: Erik Ernst <eer...@google.com>
    Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
    Gerrit-CC: Paul Berry <paul...@google.com>
    Gerrit-Attention: Erik Ernst <eer...@google.com>
    Gerrit-Attention: Chloe Stefantsova <cstefa...@google.com>
    Gerrit-Comment-Date: Mon, 09 Mar 2026 20:32:10 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages