[S] Change in dart/sdk[main]: DAS: Support primary constructors and empty bodies in convert_class_t...
0 views
Skip to first unread message
Samuel Rawlins (Gerrit)
Jan 19, 2026, 12:01:24 AM (3 days ago) Jan 19
to Konstantin Shcheglov, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Konstantin Shcheglov
Samuel Rawlins voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Konstantin Shcheglov
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Brian Wilkerson (Gerrit)
Jan 21, 2026, 1:49:41 PM (10 hours ago) Jan 21
to Samuel Rawlins, Brian Wilkerson, Konstantin Shcheglov, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Konstantin Shcheglov and Samuel Rawlins
Brian Wilkerson voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Konstantin Shcheglov
- Samuel Rawlins
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Konstantin Shcheglov (Gerrit)
Jan 21, 2026, 1:51:54 PM (10 hours ago) Jan 21
to Samuel Rawlins, Brian Wilkerson, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Samuel Rawlins
Konstantin Shcheglov voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Samuel Rawlins
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Samuel Rawlins (Gerrit)
Jan 21, 2026, 2:05:47 PM (10 hours ago) Jan 21
to Konstantin Shcheglov, Brian Wilkerson, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Samuel Rawlins voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Samuel Rawlins (Gerrit)
Jan 21, 2026, 2:36:46 PM (10 hours ago) Jan 21
to Konstantin Shcheglov, Brian Wilkerson, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Samuel Rawlins voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Commit Queue (Gerrit)
Jan 21, 2026, 3:09:17 PM (9 hours ago) Jan 21
to Samuel Rawlins, Konstantin Shcheglov, Brian Wilkerson, dart-analys...@google.com, rev...@dartlang.org
Commit Queue submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
1 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: pkg/analysis_server/lib/src/services/correction/dart/convert_class_to_mixin.dart
Insertions: 0, Deletions: 2.
The diff is too large to show. Please review the diff.
```
Change information
Commit message:
DAS: Support primary constructors and empty bodies in convert_class_to_mixin
Work towards https://github.com/dart-lang/sdk/issues/61704
Change-Id: Ic84fdb552a57257dc823fd2dfc6b2fdec123876b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/474080
Commit-Queue: Samuel Rawlins <sraw...@google.com>
Reviewed-by: Brian Wilkerson <brianwi...@google.com>
Reviewed-by: Konstantin Shcheglov <sche...@google.com>
Files:
- M pkg/analysis_server/lib/src/services/correction/dart/convert_class_to_mixin.dart
- M pkg/analysis_server/test/src/services/correction/assist/convert_class_to_mixin_test.dart
Change size: S
Delta: 2 files changed, 28 insertions(+), 7 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Konstantin Shcheglov, +1 by Brian Wilkerson
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages