[XL] Change in dart/sdk[main]: [DAS] Differentiates tearoff fixes from invocation fixes for methods ...

0 views
Skip to first unread message

Felipe Morschel (Gerrit)

unread,
Aug 7, 2025, 3:09:40 PM8/7/25
to dart-analys...@google.com, rev...@dartlang.org

Felipe Morschel has uploaded the change for review

Commit message

[DAS] Differentiates tearoff fixes from invocation fixes for methods and functions

This is mostly a no-op change to make clear to anyone reading the tests that we should probably make sure both cases are covered. This is a step towards https://github.com/dart-lang/sdk/issues/61186#issuecomment-3113493861 which will be handled in a separate CL.
Change-Id: Ib651e2d1126a7fd54ba37fe3a806d843c0f29ca4

Change information

Files:
  • M pkg/analysis_server/lib/src/services/correction/dart/create_method_or_function.dart
  • M pkg/analysis_server/lib/src/services/correction/fix.dart
  • M pkg/analysis_server/test/src/services/correction/fix/create_function_test.dart
  • M pkg/analysis_server/test/src/services/correction/fix/create_method_test.dart
Change size: XL
Delta: 4 files changed, 886 insertions(+), 850 deletions(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Ib651e2d1126a7fd54ba37fe3a806d843c0f29ca4
Gerrit-Change-Number: 444384
Gerrit-PatchSet: 1
Gerrit-Owner: Felipe Morschel <g...@fmorschel.dev>
Gerrit-Reviewer: Felipe Morschel <g...@fmorschel.dev>
unsatisfied_requirement
open
diffy

Felipe Morschel (Gerrit)

unread,
Aug 7, 2025, 3:11:54 PM8/7/25
to Brian Wilkerson, Samuel Rawlins, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Brian Wilkerson and Samuel Rawlins

Felipe Morschel added 1 comment

File pkg/analysis_server/lib/src/services/correction/dart/create_method_or_function.dart
Line 74, Patchset 1 (Latest): required this.fixKind,
Felipe Morschel . resolved

Changed this because since we never update `targetElement` within the class, it makes no sense for it to be creating a method.

Open in Gerrit

Related details

Attention is currently required from:
  • Brian Wilkerson
  • Samuel Rawlins
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Ib651e2d1126a7fd54ba37fe3a806d843c0f29ca4
Gerrit-Change-Number: 444384
Gerrit-PatchSet: 1
Gerrit-Owner: Felipe Morschel <g...@fmorschel.dev>
Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
Gerrit-Reviewer: Felipe Morschel <g...@fmorschel.dev>
Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
Gerrit-Attention: Samuel Rawlins <sraw...@google.com>
Gerrit-Attention: Brian Wilkerson <brianwi...@google.com>
Gerrit-Comment-Date: Thu, 07 Aug 2025 19:11:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Brian Wilkerson (Gerrit)

unread,
Aug 7, 2025, 3:52:51 PM8/7/25
to Felipe Morschel, Brian Wilkerson, Samuel Rawlins, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Felipe Morschel and Samuel Rawlins

Brian Wilkerson voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Felipe Morschel
  • Samuel Rawlins
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Ib651e2d1126a7fd54ba37fe3a806d843c0f29ca4
Gerrit-Change-Number: 444384
Gerrit-PatchSet: 1
Gerrit-Owner: Felipe Morschel <g...@fmorschel.dev>
Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
Gerrit-Reviewer: Felipe Morschel <g...@fmorschel.dev>
Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
Gerrit-Attention: Felipe Morschel <g...@fmorschel.dev>
Gerrit-Attention: Samuel Rawlins <sraw...@google.com>
Gerrit-Comment-Date: Thu, 07 Aug 2025 19:52:48 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Samuel Rawlins (Gerrit)

unread,
Aug 7, 2025, 7:36:48 PM8/7/25
to Felipe Morschel, Brian Wilkerson, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Felipe Morschel

Samuel Rawlins voted and added 1 comment

Votes added by Samuel Rawlins

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Samuel Rawlins . resolved

Nicely done!

Open in Gerrit

Related details

Attention is currently required from:
  • Felipe Morschel
Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: Ib651e2d1126a7fd54ba37fe3a806d843c0f29ca4
    Gerrit-Change-Number: 444384
    Gerrit-PatchSet: 1
    Gerrit-Owner: Felipe Morschel <g...@fmorschel.dev>
    Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
    Gerrit-Reviewer: Felipe Morschel <g...@fmorschel.dev>
    Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
    Gerrit-Attention: Felipe Morschel <g...@fmorschel.dev>
    Gerrit-Comment-Date: Thu, 07 Aug 2025 23:36:45 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Samuel Rawlins (Gerrit)

    unread,
    Aug 7, 2025, 7:36:52 PM8/7/25
    to Felipe Morschel, Brian Wilkerson, dart-analys...@google.com, rev...@dartlang.org
    Attention needed from Felipe Morschel

    Samuel Rawlins voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Felipe Morschel
    Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: Ib651e2d1126a7fd54ba37fe3a806d843c0f29ca4
    Gerrit-Change-Number: 444384
    Gerrit-PatchSet: 1
    Gerrit-Owner: Felipe Morschel <g...@fmorschel.dev>
    Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
    Gerrit-Reviewer: Felipe Morschel <g...@fmorschel.dev>
    Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
    Gerrit-Attention: Felipe Morschel <g...@fmorschel.dev>
    Gerrit-Comment-Date: Thu, 07 Aug 2025 23:36:49 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Commit Queue (Gerrit)

    unread,
    Aug 7, 2025, 8:10:28 PM8/7/25
    to Felipe Morschel, Samuel Rawlins, Brian Wilkerson, dart-analys...@google.com, rev...@dartlang.org

    Commit Queue submitted the change

    Change information

    Commit message:
    [DAS] Differentiates tearoff fixes from invocation fixes for methods and functions

    This is mostly a no-op change to make clear to anyone reading the tests that we should probably make sure both cases are covered. This is a step towards https://github.com/dart-lang/sdk/issues/61186#issuecomment-3113493861 which will be handled in a separate CL.
    Change-Id: Ib651e2d1126a7fd54ba37fe3a806d843c0f29ca4
    Reviewed-by: Samuel Rawlins <sraw...@google.com>
    Auto-Submit: Felipe Morschel <g...@fmorschel.dev>
    Reviewed-by: Brian Wilkerson <brianwi...@google.com>
    Commit-Queue: Samuel Rawlins <sraw...@google.com>
    Files:
    • M pkg/analysis_server/lib/src/services/correction/dart/create_method_or_function.dart
    • M pkg/analysis_server/lib/src/services/correction/fix.dart
    • M pkg/analysis_server/test/src/services/correction/fix/create_function_test.dart
    • M pkg/analysis_server/test/src/services/correction/fix/create_method_test.dart
    Change size: XL
    Delta: 4 files changed, 886 insertions(+), 850 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Samuel Rawlins, +1 by Brian Wilkerson
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: Ib651e2d1126a7fd54ba37fe3a806d843c0f29ca4
    Gerrit-Change-Number: 444384
    Gerrit-PatchSet: 2
    Gerrit-Owner: Felipe Morschel <g...@fmorschel.dev>
    Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages