[L] Change in dart/sdk[main]: linter: Introduce no_raw_types replacing strict-raw-types

0 views

Skip to first unread message

Brian Wilkerson (Gerrit)

unread,

4:48 PM (1 hour ago) 4:48 PM

to Samuel Rawlins, Connie Ooi, Brian Wilkerson, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-analys...@google.com, rev...@dartlang.org

Attention needed from Connie Ooi and Samuel Rawlins

Brian Wilkerson voted and added 2 comments

Votes added by Brian Wilkerson

Code-Review

2 comments

File pkg/analyzer/test/src/options/options_file_validator_test.dart

Line 311, Patchset 2 (Latest): @SkippedTest(reason: 'Enable when we deprecate strict-raw-types')

Brian Wilkerson . resolved

Seems like it would be better to mark this as failing. If we do, then it will be flagged when it starts to pass and we won't forget to un-skip (un-fail) it.

File pkg/linter/messages.yaml

Line 7915, Patchset 2 (Latest): deprecatedDetails: |-

Brian Wilkerson . resolved

It would be great if this included some information about why this is a problem, which cases aren't flagged, and a definition of 'raw type' (or pointer to a glossary entry). (Just trying to set a slightly higher bar for documentation. :-)

Open in Gerrit

Related details

Attention is currently required from:

Connie Ooi
Samuel Rawlins

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

satisfied_requirement

open

diffy

Konstantin Shcheglov (Gerrit)

unread,

5:10 PM (1 hour ago) 5:10 PM