[S] Change in dart/sdk[main]: [vm] Cleanup unused UntaggedPcDescriptors::kBSSRelocation

0 views
Skip to first unread message

Alexander Markov (Gerrit)

unread,
Jun 9, 2026, 1:25:22 PM (yesterday) Jun 9
to Alexander Markov, Ryan Macnak, dart-...@luci-project-accounts.iam.gserviceaccount.com, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Ryan Macnak

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Ryan Macnak
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement satisfiedCommit-Message-Has-TEST
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Ifd926f3bd3630b80c9659dbe60892c3c229bf838
Gerrit-Change-Number: 510400
Gerrit-PatchSet: 1
Gerrit-Owner: Alexander Markov <alexm...@google.com>
Gerrit-Reviewer: Alexander Markov <alexm...@google.com>
Gerrit-Reviewer: Ryan Macnak <rma...@google.com>
Gerrit-Attention: Ryan Macnak <rma...@google.com>
Gerrit-Comment-Date: Tue, 09 Jun 2026 17:25:12 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Ryan Macnak (Gerrit)

unread,
Jun 9, 2026, 1:26:26 PM (yesterday) Jun 9
to Alexander Markov, dart-...@luci-project-accounts.iam.gserviceaccount.com, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Alexander Markov

Ryan Macnak voted and added 1 comment

Votes added by Ryan Macnak

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Ryan Macnak . resolved

There's probably even more dead BSS stuff in image_snapshot.cc

Open in Gerrit

Related details

Attention is currently required from:
  • Alexander Markov
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedCommit-Message-Has-TEST
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Ifd926f3bd3630b80c9659dbe60892c3c229bf838
Gerrit-Change-Number: 510400
Gerrit-PatchSet: 1
Gerrit-Owner: Alexander Markov <alexm...@google.com>
Gerrit-Reviewer: Alexander Markov <alexm...@google.com>
Gerrit-Reviewer: Ryan Macnak <rma...@google.com>
Gerrit-Attention: Alexander Markov <alexm...@google.com>
Gerrit-Comment-Date: Tue, 09 Jun 2026 17:26:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Alexander Markov (Gerrit)

unread,
Jun 9, 2026, 1:29:19 PM (yesterday) Jun 9
to Alexander Markov, Ryan Macnak, dart-...@luci-project-accounts.iam.gserviceaccount.com, rev...@dartlang.org, vm-...@dartlang.org

Alexander Markov voted and added 1 comment

Votes added by Alexander Markov

Commit-Queue+2

1 comment

Patchset-level comments
Alexander Markov . resolved

Thank you, Ryan!

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedCommit-Message-Has-TEST
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Ifd926f3bd3630b80c9659dbe60892c3c229bf838
Gerrit-Change-Number: 510400
Gerrit-PatchSet: 1
Gerrit-Owner: Alexander Markov <alexm...@google.com>
Gerrit-Reviewer: Alexander Markov <alexm...@google.com>
Gerrit-Reviewer: Ryan Macnak <rma...@google.com>
Gerrit-Comment-Date: Tue, 09 Jun 2026 17:29:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)

unread,
Jun 9, 2026, 1:29:45 PM (yesterday) Jun 9
to Alexander Markov, Ryan Macnak, rev...@dartlang.org, vm-...@dartlang.org

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change

Change information

Commit message:
[vm] Cleanup unused UntaggedPcDescriptors::kBSSRelocation

TEST=ci
Change-Id: Ifd926f3bd3630b80c9659dbe60892c3c229bf838
Reviewed-by: Ryan Macnak <rma...@google.com>
Commit-Queue: Alexander Markov <alexm...@google.com>
Files:
  • M runtime/vm/code_descriptors.cc
  • M runtime/vm/image_snapshot.cc
  • M runtime/vm/object.cc
  • M runtime/vm/raw_object.h
Change size: S
Delta: 4 files changed, 3 insertions(+), 40 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Ryan Macnak
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Ifd926f3bd3630b80c9659dbe60892c3c229bf838
Gerrit-Change-Number: 510400
Gerrit-PatchSet: 2
Gerrit-Owner: Alexander Markov <alexm...@google.com>
Gerrit-Reviewer: Alexander Markov <alexm...@google.com>
Gerrit-Reviewer: Ryan Macnak <rma...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages