[S] Change in dart/sdk[main]: [vm] Cleanup unused UntaggedPcDescriptors::kBSSRelocation
0 views
Skip to first unread message
Alexander Markov (Gerrit)
Jun 9, 2026, 1:25:22 PM (yesterday) Jun 9
to Alexander Markov, Ryan Macnak, dart-...@luci-project-accounts.iam.gserviceaccount.com, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Ryan Macnak
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Ryan Macnak
Submit Requirements:
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ryan Macnak (Gerrit)
Jun 9, 2026, 1:26:26 PM (yesterday) Jun 9
to Alexander Markov, dart-...@luci-project-accounts.iam.gserviceaccount.com, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Alexander Markov
Ryan Macnak voted and added 1 comment![]( "Open in Gerrit")
Votes added by Ryan Macnak
| Code-Review | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Ryan Macnak . resolved
There's probably even more dead BSS stuff in image_snapshot.cc
Related details
Attention is currently required from:
- Alexander Markov
Submit Requirements:
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alexander Markov (Gerrit)
Jun 9, 2026, 1:29:19 PM (yesterday) Jun 9
to Alexander Markov, Ryan Macnak, dart-...@luci-project-accounts.iam.gserviceaccount.com, rev...@dartlang.org, vm-...@dartlang.org
Alexander Markov voted and added 1 comment![]( "Open in Gerrit")
Votes added by Alexander Markov
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Submit Requirements:
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
Jun 9, 2026, 1:29:45 PM (yesterday) Jun 9
to Alexander Markov, Ryan Macnak, rev...@dartlang.org, vm-...@dartlang.org
dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[vm] Cleanup unused UntaggedPcDescriptors::kBSSRelocation
TEST=ci
Change-Id: Ifd926f3bd3630b80c9659dbe60892c3c229bf838
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/510400
Reviewed-by: Ryan Macnak <rma...@google.com>
Commit-Queue: Alexander Markov <alexm...@google.com>
Files:
- M runtime/vm/code_descriptors.cc
- M runtime/vm/image_snapshot.cc
- M runtime/vm/object.cc
- M runtime/vm/raw_object.h
Change size: S
Delta: 4 files changed, 3 insertions(+), 40 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Ryan Macnak
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages