[XL] Change in dart/sdk[main]: Bump tools to 97014f33a2aad59385df73f25baf9c304ca5c866

0 views
Skip to first unread message

Morgan :) (Gerrit)

unread,
Dec 10, 2025, 8:28:10 AM12/10/25
to Alexander Markov, Jens Johansen, Paul Berry, Konstantin Shcheglov, dart-analys...@google.com, dart-dc-te...@google.com, dart-fe-te...@google.com, dart-uxr...@google.com, dart-vm-compil...@google.com, dart2js-te...@google.com, dart2wasm-t...@google.com, rev...@dartlang.org, vm-...@dartlang.org

Morgan :) abandoned this change

Related details

Attention set is empty
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedCommit-Message-Has-TEST
  • requirement is not satisfiedCore-Library-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: abandon
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Id78e642775315a4c52fe46887bdcde5f4e8bf649
Gerrit-Change-Number: 467301
Gerrit-PatchSet: 1
Gerrit-Owner: Morgan :) <david...@google.com>
Gerrit-CC: Alexander Markov <alexm...@google.com>
Gerrit-CC: Jens Johansen <je...@google.com>
Gerrit-CC: Konstantin Shcheglov <sche...@google.com>
Gerrit-CC: Paul Berry <paul...@google.com>
unsatisfied_requirement
open
diffy

Konstantin Shcheglov (Gerrit)

unread,
Dec 10, 2025, 11:04:09 AM12/10/25
to Morgan :), Commit Queue, rev...@dartlang.org
Attention needed from Morgan :)

Konstantin Shcheglov voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Morgan :)
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Idf3b78cdd156de2833b5367fa1ee8bcacc7a5dfb
Gerrit-Change-Number: 467302
Gerrit-PatchSet: 4
Gerrit-Owner: Morgan :) <david...@google.com>
Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
Gerrit-Reviewer: Morgan :) <david...@google.com>
Gerrit-Attention: Morgan :) <david...@google.com>
Gerrit-Comment-Date: Wed, 10 Dec 2025 16:04:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
unsatisfied_requirement
satisfied_requirement
open
diffy

Samuel Rawlins (Gerrit)

unread,
Dec 10, 2025, 11:57:09 AM12/10/25
to Morgan :), Konstantin Shcheglov, Commit Queue, rev...@dartlang.org
Attention needed from Morgan :)

Samuel Rawlins voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Morgan :)
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Idf3b78cdd156de2833b5367fa1ee8bcacc7a5dfb
Gerrit-Change-Number: 467302
Gerrit-PatchSet: 4
Gerrit-Owner: Morgan :) <david...@google.com>
Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
Gerrit-Reviewer: Morgan :) <david...@google.com>
Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
Gerrit-Attention: Morgan :) <david...@google.com>
Gerrit-Comment-Date: Wed, 10 Dec 2025 16:57:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Morgan :) (Gerrit)

unread,
Dec 10, 2025, 2:27:23 PM12/10/25
to Samuel Rawlins, Konstantin Shcheglov, Commit Queue, rev...@dartlang.org

Morgan :) voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Idf3b78cdd156de2833b5367fa1ee8bcacc7a5dfb
Gerrit-Change-Number: 467302
Gerrit-PatchSet: 4
Gerrit-Owner: Morgan :) <david...@google.com>
Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
Gerrit-Reviewer: Morgan :) <david...@google.com>
Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
Gerrit-Comment-Date: Wed, 10 Dec 2025 19:27:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Commit Queue (Gerrit)

unread,
Dec 10, 2025, 2:27:37 PM12/10/25
to Morgan :), Samuel Rawlins, Konstantin Shcheglov, rev...@dartlang.org

Commit Queue submitted the change

Change information

Commit message:
Bump tools to 97014f33a2aad59385df73f25baf9c304ca5c866

For the Linux bug fix http://github.com/dart-lang/tools/pull/2273.

Fix analyzer test expectation due to yaml_edit change https://github.com/dart-lang/tools/pull/2259.

Changes:
```
> git log --format="%C(auto) %h %s" d03c394..97014f3
https://dart.googlesource.com/tools.git/+/97014f33 Move files, rename classes: "MacOS" watcher is used on Windows too. (2274)
https://dart.googlesource.com/tools.git/+/db8f0b87 Use the MacOS directory watcher on Windows too. (2272)
https://dart.googlesource.com/tools.git/+/32bdd7d7 Fix exception on Linux due to unexpected "modify directory". (2273)
https://dart.googlesource.com/tools.git/+/a6545304 Rewrite MacOS directory watcher. (2268)
https://dart.googlesource.com/tools.git/+/ca52a3e6 [bazer_worker] allow latest pkg:protobuf (2265)
https://dart.googlesource.com/tools.git/+/3849511d Fix alphabetical ordering single element map (2259)

```
Change-Id: Idf3b78cdd156de2833b5367fa1ee8bcacc7a5dfb
Reviewed-by: Samuel Rawlins <sraw...@google.com>
Reviewed-by: Konstantin Shcheglov <sche...@google.com>
Commit-Queue: Morgan :) <david...@google.com>
Files:
  • M DEPS
  • M pkg/analysis_server/test/src/services/correction/fix/ignore_diagnostic_test.dart
Change size: XS
Delta: 2 files changed, 3 insertions(+), 3 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Konstantin Shcheglov, +1 by Samuel Rawlins
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Idf3b78cdd156de2833b5367fa1ee8bcacc7a5dfb
Gerrit-Change-Number: 467302
Gerrit-PatchSet: 5
Gerrit-Owner: Morgan :) <david...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages