[S] Change in dart/sdk[main]: [dart2wasm] Avoid O(n) scan to find module for a [Library].

0 views
Skip to first unread message

Ömer Ağacan (Gerrit)

unread,
Nov 28, 2025, 3:58:57 AM (yesterday) Nov 28
to Martin Kustermann, Commit Queue, dart2wasm-t...@google.com, rev...@dartlang.org
Attention needed from Martin Kustermann

Ömer Ağacan voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Martin Kustermann
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I6e0a6813b8519b9432d4f7da18cfca1153d813c5
Gerrit-Change-Number: 464900
Gerrit-PatchSet: 3
Gerrit-Owner: Martin Kustermann <kuste...@google.com>
Gerrit-Reviewer: Martin Kustermann <kuste...@google.com>
Gerrit-Reviewer: Ömer Ağacan <ome...@google.com>
Gerrit-Attention: Martin Kustermann <kuste...@google.com>
Gerrit-Comment-Date: Fri, 28 Nov 2025 08:58:51 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Martin Kustermann (Gerrit)

unread,
Nov 28, 2025, 4:44:59 AM (yesterday) Nov 28
to Ömer Ağacan, Commit Queue, dart2wasm-t...@google.com, rev...@dartlang.org

Martin Kustermann voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I6e0a6813b8519b9432d4f7da18cfca1153d813c5
Gerrit-Change-Number: 464900
Gerrit-PatchSet: 3
Gerrit-Owner: Martin Kustermann <kuste...@google.com>
Gerrit-Reviewer: Martin Kustermann <kuste...@google.com>
Gerrit-Reviewer: Ömer Ağacan <ome...@google.com>
Gerrit-Comment-Date: Fri, 28 Nov 2025 09:44:53 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Commit Queue (Gerrit)

unread,
Nov 28, 2025, 4:45:19 AM (yesterday) Nov 28
to Martin Kustermann, Ömer Ağacan, dart2wasm-t...@google.com, rev...@dartlang.org

Commit Queue submitted the change

Change information

Commit message:
[dart2wasm] Avoid O(n) scan to find module for a [Library].
Change-Id: I6e0a6813b8519b9432d4f7da18cfca1153d813c5
Reviewed-by: Ömer Ağacan <ome...@google.com>
Commit-Queue: Martin Kustermann <kuste...@google.com>
Files:
  • M pkg/dart2wasm/lib/modules.dart
Change size: S
Delta: 1 file changed, 9 insertions(+), 9 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Ömer Ağacan
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I6e0a6813b8519b9432d4f7da18cfca1153d813c5
Gerrit-Change-Number: 464900
Gerrit-PatchSet: 4
Gerrit-Owner: Martin Kustermann <kuste...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages