Groups keyboard shortcuts have been updated
Dismiss
See shortcuts
[S] Change in dart/sdk[main]: DAS: Un-cache the assist lint rule map when registering new generators
0 views
Skip to first unread message
Konstantin Shcheglov (Gerrit)
Mar 14, 2025, 4:17:39 PMMar 14
to Samuel Rawlins, Brian Wilkerson, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Brian Wilkerson and Samuel Rawlins
Konstantin Shcheglov voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Brian Wilkerson
- Samuel Rawlins
Submit Requirements:
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Brian Wilkerson (Gerrit)
Mar 14, 2025, 4:20:28 PMMar 14
to Samuel Rawlins, Brian Wilkerson, Konstantin Shcheglov, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Samuel Rawlins
Brian Wilkerson voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Samuel Rawlins
Submit Requirements:
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Samuel Rawlins (Gerrit)
Mar 14, 2025, 4:28:43 PMMar 14
to Brian Wilkerson, Konstantin Shcheglov, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Samuel Rawlins voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Commit Queue (Gerrit)
Mar 14, 2025, 5:06:48 PMMar 14
to Samuel Rawlins, Brian Wilkerson, Konstantin Shcheglov, dart-analys...@google.com, rev...@dartlang.org
Commit Queue submitted the change![]( "Open in Gerrit")
Change information
Commit message:
DAS: Un-cache the assist lint rule map when registering new generators
This fixes running
`dart --enable-asserts pkg/analysis_server/test/test_all.dart`.
Change-Id: I50aef9e2d2f073ac8917b3f97dcfc0cddc0290c3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/415720
Reviewed-by: Konstantin Shcheglov <sche...@google.com>
Reviewed-by: Brian Wilkerson <brianwi...@google.com>
Commit-Queue: Samuel Rawlins <sraw...@google.com>
Files:
- M pkg/analysis_server/lib/src/services/correction/assist_generators.dart
- M pkg/analysis_server/lib/src/services/correction/assist_internal.dart
Change size: S
Delta: 2 files changed, 18 insertions(+), 11 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Konstantin Shcheglov, +1 by Brian Wilkerson
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages