[S] Change in dart/sdk[main]: Send IDE and plugin info to analytics

0 views

Skip to first unread message

Helin Shiah (Gerrit)

unread,

Apr 21, 2026, 5:18:58 PM (18 hours ago) Apr 21

to Keerti Parthasarathy, dart-analys...@google.com, rev...@dartlang.org

Attention needed from Keerti Parthasarathy

Helin Shiah added 1 comment

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Helin Shiah . resolved

I was able to check with the logger that the IDE information is available right before `analytics.send` for `serverSession` (around line 757 in `analytics_manager.dart`); however, I was not able to verify that this data is truly sent to the database and visible in Bigquery.

Open in Gerrit

Related details

Attention is currently required from:

Keerti Parthasarathy

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Brian Wilkerson (Gerrit)

unread,

Apr 21, 2026, 5:49:48 PM (18 hours ago) Apr 21

to Helin Shiah, Brian Wilkerson, Keerti Parthasarathy, dart-analys...@google.com, rev...@dartlang.org

Attention needed from Helin Shiah and Keerti Parthasarathy

Brian Wilkerson added 1 comment

File pkg/analysis_server/lib/src/analytics/session_data.dart

Line 137, Patchset 3 (Latest): final String ideName;

Brian Wilkerson . unresolved

I believe that the rest of the data being captured in this object is data that isn't available when we send the event, and hence needs to be captured at start-up and stored for later use.

That isn't true of these four values. They're stored in environment variables that will still be accessible when we send the event.

Consider not storing them and just accessing them when we're about to send the event.