[M] Change in dart/sdk[main]: [migrate] Allow the tool to perform dry runs.

[Kallen Tu (Gerrit)]

Attention needed from Brian Wilkerson

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:

• Brian Wilkerson

Submit Requirements:

• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: sdk

Gerrit-Branch: main

Gerrit-Change-Id: Ib5f841fabfd135477af973ac55cdfc6b34aa959b

Gerrit-Change-Number: 516460

Gerrit-PatchSet: 3

Gerrit-Owner: Kallen Tu <kall...@google.com>

Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>

Gerrit-Reviewer: Kallen Tu <kall...@google.com>

Gerrit-CC: dart-...@luci-project-accounts.iam.gserviceaccount.com <dart-...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Brian Wilkerson <brianwi...@google.com>

Gerrit-Comment-Date: Tue, 23 Jun 2026 22:40:11 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: No

[Brian Wilkerson (Gerrit)]

Attention needed from Kallen Tu

Brian Wilkerson voted and added 2 comments

Votes added by Brian Wilkerson

Code-Review

+1

2 comments

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Brian Wilkerson . resolved

In the case of `dart fix`, the logic around apply/dryRun is all done in the client. The server computes a result and sends it back to the client, and the client either applies the edits or not. The server doesn't actually need to know whether the edits will be applied.

It's also the case that the display logic is all located in the client, so most of the verbiage is composed on the client side from the data returned by the server. I kind of like this split in responsibility, but I'll let you decide how you want to architect it.

File pkg/analysis_server/tool/lsp_spec/custom/dart_migrate.dart

Line 19, Patchset 3 (Latest): field(

Brian Wilkerson . resolved

If you decide to keep the apply/dryRun logic in the server, consider replacing this with a single field (maybe an enum or a bool) and minimally do the validation on the client side. It would have the benefit that if the user forgets to provide a flag they won't have to wait for a server to spin up before they can be told about the error.

Open in Gerrit

Related details

Attention is currently required from:

• Kallen Tu

Submit Requirements:

• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: sdk

Gerrit-Branch: main

Gerrit-Change-Id: Ib5f841fabfd135477af973ac55cdfc6b34aa959b

Gerrit-Change-Number: 516460

Gerrit-PatchSet: 3

Gerrit-Owner: Kallen Tu <kall...@google.com>

Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>

Gerrit-Reviewer: Kallen Tu <kall...@google.com>

Gerrit-CC: dart-...@luci-project-accounts.iam.gserviceaccount.com <dart-...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Kallen Tu <kall...@google.com>

Gerrit-Comment-Date: Tue, 23 Jun 2026 23:20:55 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes