[L] Change in dart/sdk[main]: Fix convertToInitializingFormal to rename references to the parameter

0 views

Skip to first unread message

Brian Wilkerson (Gerrit)

unread,

5:33 PM (2 hours ago) 5:33 PM

to Brian Wilkerson, Samuel Rawlins, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-analys...@google.com, rev...@dartlang.org

Attention needed from Brian Wilkerson and Samuel Rawlins

Brian Wilkerson voted Commit-Queue+1

Commit-Queue

Open in Gerrit

Related details

Attention is currently required from:

Brian Wilkerson
Samuel Rawlins

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Samuel Rawlins (Gerrit)

unread,

6:00 PM (1 hour ago) 6:00 PM

to Brian Wilkerson, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-analys...@google.com, rev...@dartlang.org

Attention needed from Brian Wilkerson

Samuel Rawlins voted and added 2 comments

Votes added by Samuel Rawlins

Code-Review

2 comments

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Samuel Rawlins . resolved

Looks great!

File pkg/analysis_server/lib/src/services/correction/dart/convert_to_initializing_formal.dart

Line 227, Patchset 1 (Latest): required ChangeBuilder builder,

Samuel Rawlins . resolved

I like this change 😄

Open in Gerrit

Related details

Attention is currently required from:

Brian Wilkerson

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages