[XL] Change in dart/sdk[main]: Patterns. Fix for parsing nested pattern assigment: 'v2 = (v1) = 0'.

0 views

Skip to first unread message

Konstantin Shcheglov (Gerrit)

unread,

Jun 2, 2026, 9:04:32 PM (20 hours ago) Jun 2

to Johnni Winther, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-analys...@google.com, rev...@dartlang.org

Attention needed from Johnni Winther and Konstantin Shcheglov

Konstantin Shcheglov voted Commit-Queue+1

Commit-Queue

Open in Gerrit

Related details

Attention is currently required from:

Johnni Winther
Konstantin Shcheglov

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Johnni Winther (Gerrit)

unread,

8:37 AM (9 hours ago) 8:37 AM

to Konstantin Shcheglov, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-analys...@google.com, rev...@dartlang.org

Attention needed from Konstantin Shcheglov

Johnni Winther voted Code-Review+1

Code-Review

Open in Gerrit

Related details

Attention is currently required from:

Konstantin Shcheglov

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Konstantin Shcheglov (Gerrit)

unread,

11:52 AM (5 hours ago) 11:52 AM

to Johnni Winther, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-analys...@google.com, rev...@dartlang.org

Konstantin Shcheglov submitted the change

Change information

Commit message:

Patterns. Fix for parsing nested pattern assigment: 'v2 = (v1) = 0'.

Change-Id: I4b3460dd57834eb52b4703c983ca6f8ed60fe270

Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/508684

Reviewed-by: Johnni Winther <johnni...@google.com>

Files:

M pkg/_fe_analyzer_shared/lib/src/parser/parser_impl.dart
M pkg/analyzer/test/generated/patterns_parser_test.dart
M pkg/front_end/parser_testcases/also-nnbd/issue_39326.dart.intertwined.expect
M pkg/front_end/parser_testcases/also-nnbd/issue_40267_conditional.dart.intertwined.expect
M pkg/front_end/parser_testcases/also-nnbd/issue_40267_conditional_2.dart.intertwined.expect
M pkg/front_end/parser_testcases/also-nnbd/issue_40267_conditional_3.dart.intertwined.expect
M pkg/front_end/parser_testcases/also-nnbd/issue_40267_conditional_4.dart.intertwined.expect
M pkg/front_end/parser_testcases/anonymous_methods/null_aware_access.dart.intertwined.expect
M pkg/front_end/parser_testcases/anonymous_methods/null_aware_access_error.dart.intertwined.expect
M pkg/front_end/parser_testcases/anonymous_methods/null_aware_cascade.dart.intertwined.expect
M pkg/front_end/parser_testcases/anonymous_methods/null_aware_cascade_error.dart.intertwined.expect
M pkg/front_end/parser_testcases/anonymous_methods/plain_access.dart.intertwined.expect
M pkg/front_end/parser_testcases/anonymous_methods/plain_access_error.dart.intertwined.expect
M pkg/front_end/parser_testcases/anonymous_methods/plain_cascade.dart.intertwined.expect
M pkg/front_end/parser_testcases/anonymous_methods/plain_cascade_error.dart.intertwined.expect
M pkg/front_end/parser_testcases/coverage/bar_eq.dart.intertwined.expect
M pkg/front_end/parser_testcases/coverage/slash_eq.dart.intertwined.expect
M pkg/front_end/parser_testcases/error_recovery/constructor_recovery_bad_name_general.crash_dart.intertwined.expect
M pkg/front_end/parser_testcases/error_recovery/constructor_recovery_bad_name_get.crash_dart.intertwined.expect
M pkg/front_end/parser_testcases/error_recovery/constructor_recovery_bad_name_return_type.crash_dart.intertwined.expect
M pkg/front_end/parser_testcases/error_recovery/constructor_recovery_bad_name_set.crash_dart.intertwined.expect
M pkg/front_end/parser_testcases/error_recovery/constructor_recovery_get.dart.intertwined.expect
M pkg/front_end/parser_testcases/error_recovery/constructor_recovery_ok.dart.intertwined.expect
M pkg/front_end/parser_testcases/error_recovery/constructor_recovery_return_type.dart.intertwined.expect
M pkg/front_end/parser_testcases/error_recovery/constructor_recovery_set.dart.intertwined.expect
M pkg/front_end/parser_testcases/error_recovery/issue_26810.dart.intertwined.expect
M pkg/front_end/parser_testcases/error_recovery/issue_26810_and.dart.intertwined.expect
M pkg/front_end/parser_testcases/error_recovery/issue_26810_or.dart.intertwined.expect
M pkg/front_end/parser_testcases/error_recovery/issue_48411.dart.intertwined.expect
M pkg/front_end/parser_testcases/error_recovery/issue_48411_prime.dart.intertwined.expect
M pkg/front_end/parser_testcases/error_recovery/issue_48411_prime_1.dart.intertwined.expect
M pkg/front_end/parser_testcases/error_recovery/issue_54284.dart.intertwined.expect
M pkg/front_end/parser_testcases/general/assignment.dart.intertwined.expect
M pkg/front_end/parser_testcases/general/call_on_after_try_block4.dart.intertwined.expect
M pkg/front_end/parser_testcases/general/call_on_after_try_block4_prime.dart.intertwined.expect
M pkg/front_end/parser_testcases/general/for_no_decl.dart.intertwined.expect
M pkg/front_end/parser_testcases/general/function_reference_following_token.dart.intertwined.expect
M pkg/front_end/parser_testcases/general/issue_41121.dart.intertwined.expect
M pkg/front_end/parser_testcases/general/new_as_identifier.dart.intertwined.expect
M pkg/front_end/parser_testcases/nnbd/issue_39286_2.dart.intertwined.expect
M pkg/front_end/parser_testcases/nnbd/issue_39286_2_prime.dart.intertwined.expect
M pkg/front_end/parser_testcases/nnbd/issue_39326.dart.intertwined.expect
M pkg/front_end/parser_testcases/nnbd/issue_39723.dart.intertwined.expect
M pkg/front_end/parser_testcases/nnbd/issue_39723_prime.dart.intertwined.expect
M pkg/front_end/parser_testcases/nnbd/issue_39776.dart.intertwined.expect
M pkg/front_end/parser_testcases/nnbd/issue_39776_prime1.dart.intertwined.expect
M pkg/front_end/parser_testcases/nnbd/issue_39776_prime2.dart.intertwined.expect
M pkg/front_end/parser_testcases/nnbd/issue_40267_case_01_2.dart.intertwined.expect
M pkg/front_end/parser_testcases/nnbd/issue_40267_case_02_2.dart.intertwined.expect
M pkg/front_end/parser_testcases/nnbd/issue_40267_case_03_2.dart.intertwined.expect
M pkg/front_end/parser_testcases/nnbd/issue_40267_case_04_2.dart.intertwined.expect
M pkg/front_end/parser_testcases/nnbd/issue_40267_case_05_2.dart.intertwined.expect
M pkg/front_end/parser_testcases/nnbd/issue_40267_conditional.dart.intertwined.expect
M pkg/front_end/parser_testcases/nnbd/issue_40267_conditional_2.dart.intertwined.expect
M pkg/front_end/parser_testcases/nnbd/issue_40267_index_access.dart.intertwined.expect
M pkg/front_end/parser_testcases/nnbd/issue_40267_index_set.dart.intertwined.expect
M pkg/front_end/parser_testcases/nnbd/issue_40267_lookup_plus.dart.intertwined.expect
M pkg/front_end/parser_testcases/nnbd/issue_40267_lookup_plus_plus.dart.intertwined.expect
M pkg/front_end/parser_testcases/nnbd/issue_40267_method_call_no_type_arguments.dart.intertwined.expect
M pkg/front_end/parser_testcases/nnbd/issue_40267_method_call_with_type_arguments.dart.intertwined.expect
M pkg/front_end/parser_testcases/nnbd/issue_40267_plus_plus_lookup.dart.intertwined.expect
M pkg/front_end/parser_testcases/nnbd/issue_40834_01.dart.intertwined.expect
M pkg/front_end/parser_testcases/nnbd/issue_40834_02.dart.intertwined.expect
M pkg/front_end/parser_testcases/nnbd/issue_40834_03.dart.intertwined.expect
M pkg/front_end/parser_testcases/nnbd/issue_41177.dart.intertwined.expect
M pkg/front_end/parser_testcases/nnbd/issue_42621.dart.intertwined.expect
M pkg/front_end/parser_testcases/nnbd/issue_47020.dart.intertwined.expect
M pkg/front_end/parser_testcases/nnbd/issue_49132.dart.intertwined.expect
M pkg/front_end/parser_testcases/nnbd/issue_49132_not_nullable.dart.intertwined.expect
M pkg/front_end/parser_testcases/nnbd/issue_49132_prime.dart.intertwined.expect
M pkg/front_end/parser_testcases/nnbd/late_modifier.dart.intertwined.expect
M pkg/front_end/parser_testcases/nnbd/null_shorting_index.dart.intertwined.expect
M pkg/front_end/parser_testcases/patterns/error_recovery_after_question_suffix_in_expression.dart.intertwined.expect
M pkg/front_end/parser_testcases/patterns/patternVariableDeclarationStatement_disallowsConst.dart.intertwined.expect
M pkg/front_end/parser_testcases/patterns/typeQuestionBeforeWhen_conditional.dart.intertwined.expect
M pkg/front_end/parser_testcases/patterns/typeQuestionBeforeWhen_guard.dart.intertwined.expect
M pkg/front_end/parser_testcases/primary_constructors/constructor_head.dart.intertwined.expect
M pkg/front_end/parser_testcases/primary_constructors/constructor_head_pre_feature.dart.intertwined.expect
M pkg/front_end/parser_testcases/primary_constructors/new_in_initializer.dart.intertwined.expect
M pkg/front_end/parser_testcases/primary_constructors/new_new.dart.intertwined.expect
M pkg/front_end/parser_testcases/primary_constructors/new_qualified_name.dart.intertwined.expect
M pkg/front_end/parser_testcases/record/is_record_conditional_expression.dart.intertwined.expect

Change size: XL

Delta: 82 files changed, 997 insertions(+), 93 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Johnni Winther

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages