[XS] Change in dart/sdk[main]: [build] Extract C++-only warning flags in GN compiler configs
0 views
Skip to first unread message
Kevin Moore (Gerrit)
Jun 8, 2026, 4:00:07 PM (6 days ago) Jun 8
to dart-...@luci-project-accounts.iam.gserviceaccount.com, rev...@dartlang.org
Attention needed from Kevin Moore
Message from Kevin Moore![]( "Open in Gerrit")
Set Ready For Review
Related details
Attention is currently required from:
- Kevin Moore
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ryan Macnak (Gerrit)
Jun 8, 2026, 4:48:01 PM (6 days ago) Jun 8
to Kevin Moore, dart-...@luci-project-accounts.iam.gserviceaccount.com, rev...@dartlang.org
Attention needed from Kevin Moore
Ryan Macnak added 1 comment![]( "Open in Gerrit")
File build/config/compiler/BUILD.gn
Line 688, Patchset 6 (Latest):
"-Wno-tsan", # Use of std::atomic_thread_fence in the STL.Ryan Macnak . unresolved
This is not a C++ only flag.
Related details
Attention is currently required from:
- Kevin Moore
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kevin Moore (Gerrit)
Jun 8, 2026, 8:27:38 PM (6 days ago) Jun 8
to Ryan Macnak, dart-...@luci-project-accounts.iam.gserviceaccount.com, rev...@dartlang.org
Attention needed from Ryan Macnak
Kevin Moore voted and added 2 comments![]( "Open in Gerrit")
Votes added by Kevin Moore
| Auto-Submit | +1 |
| Commit-Queue | +1 |
2 comments
Patchset-level comments
File build/config/compiler/BUILD.gn
Line 688, Patchset 6:
"-Wno-tsan", # Use of std::atomic_thread_fence in the STL.Ryan Macnak . resolved
This is not a C++ only flag.
Attention is currently required from:
- Ryan Macnak
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ryan Macnak (Gerrit)
Jun 9, 2026, 11:37:46 AM (5 days ago) Jun 9
to Kevin Moore, dart-...@luci-project-accounts.iam.gserviceaccount.com, rev...@dartlang.org
Attention needed from Kevin Moore
Ryan Macnak voted and added 1 comment![]( "Open in Gerrit")
Votes added by Ryan Macnak
| Code-Review | +1 |
1 comment
Commit Message
Line 11, Patchset 7 (Latest):
'default_warning_flags_cc'. This caused these flags (such as
-Wno-microsoft-unqualified-friend, -Wno-microsoft-cast, and -Wno-tsan)Ryan Macnak . unresolved
Stale comment
Related details
Attention is currently required from:
- Kevin Moore
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kevin Moore (Gerrit)
Jun 9, 2026, 11:58:50 AM (5 days ago) Jun 9
to Ryan Macnak, dart-...@luci-project-accounts.iam.gserviceaccount.com, rev...@dartlang.org
Kevin Moore voted and added 1 comment![]( "Open in Gerrit")
Votes added by Kevin Moore
| Auto-Submit | +1 |
| Commit-Queue | +2 |
1 comment
Commit Message
Line 11, Patchset 7:
'default_warning_flags_cc'. This caused these flags (such as
-Wno-microsoft-unqualified-friend, -Wno-microsoft-cast, and -Wno-tsan)Ryan Macnak . resolved
Kevin MooreStale comment
Done
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
Jun 9, 2026, 11:59:03 AM (5 days ago) Jun 9
to Kevin Moore, Ryan Macnak, rev...@dartlang.org
dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Unreviewed changes
7 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
[build] Extract C++-only warning flags in GN compiler configs
Several C++-only warning suppressions were incorrectly placed in the
shared 'default_warning_flags' list instead of
'default_warning_flags_cc'. This caused these flags (such as
-Wno-microsoft-unqualified-friend, -Wno-microsoft-cast)
to be applied to pure C targets (like zlib and BoringSSL assembly).
This CL moves these C++-only warnings to 'default_warning_flags_cc',
ensuring they are only applied to C++ compilation units. This improves
compile database accuracy, prevents IDE/clangd from surfacing phantom
diagnostics on C files, and makes the build configuration explicit and
robust.
Change-Id: I117de03496164d7e2e39b5deab7754fd85452923
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/510181
Commit-Queue: Kevin Moore <kev...@google.com>
Reviewed-by: Ryan Macnak <rma...@google.com>
Auto-Submit: Kevin Moore <kev...@google.com>
Files:
- M build/config/compiler/BUILD.gn
Change size: XS
Delta: 1 file changed, 3 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Ryan Macnak
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages