[M] Change in dart/sdk[main]: linter: Support extension types in avoid_slow_async_io rule
0 views
Skip to first unread message
Brian Wilkerson (Gerrit)
Mar 9, 2026, 11:33:27 AM (16 hours ago) Mar 9
to Samuel Rawlins, Brian Wilkerson, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Samuel Rawlins
Brian Wilkerson voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Samuel Rawlins
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Samuel Rawlins (Gerrit)
Mar 9, 2026, 12:54:22 PM (14 hours ago) Mar 9
to Brian Wilkerson, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Samuel Rawlins voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Commit Queue (Gerrit)
Mar 9, 2026, 12:54:34 PM (14 hours ago) Mar 9
to Samuel Rawlins, Brian Wilkerson, dart-analys...@google.com, rev...@dartlang.org
Commit Queue submitted the change![]( "Open in Gerrit")
Change information
Commit message:
linter: Support extension types in avoid_slow_async_io rule
An invocation of one of the methods in question (like File.exists),
when invoked on an extension type "instance," should trigger the same
as an invocation of File.exists.
The rule should not trigger for redeclarations.
Work towards https://github.com/dart-lang/sdk/issues/58838
Change-Id: Ia32c59902d5a28fcff8a1a3b7178062ef78394bc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/486420
Commit-Queue: Samuel Rawlins <sraw...@google.com>
Reviewed-by: Brian Wilkerson <brianwi...@google.com>
Files:
- M pkg/linter/lib/src/extensions.dart
- M pkg/linter/lib/src/rules/avoid_slow_async_io.dart
- M pkg/linter/test/rules/avoid_slow_async_io_test.dart
Change size: M
Delta: 3 files changed, 57 insertions(+), 43 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Brian Wilkerson
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages