[XS] Change in dart/sdk[main]: [build] Generate debug info for assembly.
0 views
Skip to first unread message
Ryan Macnak (Gerrit)
Mar 9, 2026, 12:56:32 PM (14 hours ago) Mar 9
to Alexander Aprelev, Commit Queue, rev...@dartlang.org
Attention needed from Alexander Aprelev
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Alexander Aprelev
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alexander Aprelev (Gerrit)
Mar 9, 2026, 12:58:28 PM (14 hours ago) Mar 9
to Ryan Macnak, Alexander Aprelev, Commit Queue, rev...@dartlang.org
Attention needed from Ryan Macnak
Alexander Aprelev voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Ryan Macnak
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ryan Macnak (Gerrit)
Mar 9, 2026, 1:45:10 PM (13 hours ago) Mar 9
to Alexander Aprelev, Commit Queue, rev...@dartlang.org
Ryan Macnak voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Commit Queue (Gerrit)
Mar 9, 2026, 1:45:25 PM (13 hours ago) Mar 9
to Ryan Macnak, Alexander Aprelev, rev...@dartlang.org
Commit Queue submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[build] Generate debug info for assembly.
This allows bloaty to attribute functions (but not variables) written in assembly to their source file. Which in turn allows the binary_size visualization to group, e.g., all the boringssl crypto kernels under boringssl instead of them all appearing at the top level.
Change-Id: I6f601f44931d6c3d2fe2018a43804b070643fba5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/486520
Reviewed-by: Alexander Aprelev <a...@google.com>
Commit-Queue: Ryan Macnak <rma...@google.com>
Files:
- M build/config/compiler/BUILD.gn
Change size: XS
Delta: 1 file changed, 1 insertion(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Alexander Aprelev
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages