[M] Change in dart/sdk[main]: Update the documentation on refactors to be more clear
0 views
Skip to first unread message
Brian Wilkerson (Gerrit)
Mar 27, 2026, 5:18:51 PM (3 days ago) Mar 27
to Brian Wilkerson, Danny Tuppeny, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Danny Tuppeny
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Danny Tuppeny
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Danny Tuppeny (Gerrit)
7:46 AM (13 hours ago) 7:46 AM
to Brian Wilkerson, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Brian Wilkerson
Danny Tuppeny added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Danny Tuppeny . resolved
lgtm, thanks!
(I can't vote though, so you'll need another reviewer)
Related details
Attention is currently required from:
- Brian Wilkerson
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Samuel Rawlins (Gerrit)
11:56 AM (9 hours ago) 11:56 AM
to Brian Wilkerson, Danny Tuppeny, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Brian Wilkerson
Samuel Rawlins voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Brian Wilkerson
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Brian Wilkerson (Gerrit)
12:00 PM (9 hours ago) 12:00 PM
to Brian Wilkerson, Samuel Rawlins, Danny Tuppeny, dart-analys...@google.com, rev...@dartlang.org
Brian Wilkerson voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Commit Queue (Gerrit)
12:30 PM (8 hours ago) 12:30 PM
to Brian Wilkerson, Samuel Rawlins, Danny Tuppeny, dart-analys...@google.com, rev...@dartlang.org
Commit Queue submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Update the documentation on refactors to be more clear
I have attempted to make the doc more clear about the differences
between the different kinds of refactors.
I have also attempted to capture some of the conditions under which I
think it's reasonable for refactors to introduce diagnostics.
Let me know if it needs more work.
Change-Id: I2307f9e5eb9d3c0daa0b584dcde65b2c3d652f81
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/491342
Commit-Queue: Brian Wilkerson <brianwi...@google.com>
Reviewed-by: Samuel Rawlins <sraw...@google.com>
Files:
- M pkg/analysis_server/doc/design/features/refactors.md
Change size: M
Delta: 1 file changed, 34 insertions(+), 18 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Samuel Rawlins
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages