[XS] Change in dart/sdk[main]: Bump test to 4838365e7fb3a2d0302cdbbd8330b7884f7d3c0d
Nate Bosch (Gerrit)
Nate Bosch voted and added 1 comment![]( "Open in Gerrit")
Votes added by Nate Bosch
| Auto-Submit | +1 |
1 comment
Nate BoschWas https://github.com/dart-lang/sdk/issues/63923 addressed?
(Test timeouts and failure in the Flutter engine are likely related and probably caused by much more Dart code imported into `package:test/test.dart` after package:test roll. Compiling many additional Dart libraries can slow down tests causing timeouts and could trigger GC which caused Flutter engine test failure.)
Nate BoschWhere do we configure the timeouts? Who should we direct this issue to address the performance issues?
I can check whether there are libraries I can prune, but if we started failing after only increasing the `package:test` imports it suggests we were already very close to some limit before.
Alexander MarkovIf it's the `package:test` timeout during compilation we can bump when we run the tests, I just need a pointer to where we are configuring and running the tests.
Nate BoschI'm afraid the regression is very severe and will affect users of `package:test`.
On the following empty test which uses `package:test`:```
import 'package:test/test.dart';void main() {}
``````
time out/ReleaseX64/dartvm foo.dartBefore:
real 0m6.672s
user 0m10.408s
sys 0m1.150sAfter:
real 0m16.978s
user 0m26.444s
sys 0m2.168s
```
Almost all this time is spent on compiling package:test and its dependencies (as `main` is empty).Size of the kernel binary of this test:
```
Before: 4185304
After: 28737088
```Number of Dart libraries compiled in this test:
```
Before: 321
After: 860
```So the regression for startup latency for the empty test is about 2.5x. The amount of compiled Dart code increased considerably - this simple empty test now imports the whole `package:analyzer` along with its dependencies. I think the right fix would be to avoid depending on analyzer, rather than increasing timeout.
Done
Related details
- Alexander Markov
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alexander Markov (Gerrit)
Alexander Markov voted![]( "Open in Gerrit")
- Nate Bosch
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Change information
Bump test to 4838365e7fb3a2d0302cdbbd8330b7884f7d3c0d
The failures in flutter engine tests which caused a rollback last time this was
rolled were fixed in https://github.com/flutter/flutter/pull/190310
Changes:
```
> git log --format="%C(auto) %h %s" bd92e63..4838365
https://dart.googlesource.com/test.git/+/4838365e Avoid transitive imports to package:analyzer (2712)
https://dart.googlesource.com/test.git/+/70ac3ff4 [test] Support CLI compiler for sanitizer runtimes (2708)
https://dart.googlesource.com/test.git/+/bdc37221 Avoid read-all permissions in dart.yml CI action (2713)
https://dart.googlesource.com/test.git/+/a9a44427 Annotate async expectations with awaitNotRequired (2700)
https://dart.googlesource.com/test.git/+/5fcd6f40 Remove unnecessary remote debugging flag (2705)
https://dart.googlesource.com/test.git/+/72d6dfcc Launch browsers with redirecting files (2703)
https://dart.googlesource.com/test.git/+/8ab38846 Disable more backgrounding features on chromium (2680)
https://dart.googlesource.com/test.git/+/d835f706 Only print debug URL when debugging (2702)
https://dart.googlesource.com/test.git/+/9abe202a Ignore dart2js output for successful compiles (2701)
https://dart.googlesource.com/test.git/+/ce557ba1 Group messages with passing tests (2699)
https://dart.googlesource.com/test.git/+/d79747cd Make workflow files more secure (2698)
https://dart.googlesource.com/test.git/+/91ca13f0 Support DART_TEST_REPORTER environment variable (2692)
https://dart.googlesource.com/test.git/+/dcb06ac7 Bump the github-actions group with 3 updates (2689)
```
Diff: https://dart.googlesource.com/test.git/+/bd92e633e7f05edc3301865bdc00d1ae181cb1f1..4838365e7fb3a2d0302cdbbd8330b7884f7d3c0d/
Change-Id: I19bf36546a3d85951185d70a859c24b5606e3d67
Tested: Package roll
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/530060
Auto-Submit: Nate Bosch <nbo...@google.com>
Commit-Queue: Alexander Markov <alexm...@google.com>
Reviewed-by: Alexander Markov <alexm...@google.com>
- M DEPS
- M pkg/vm/testcases/transformations/type_flow/transformer/protobuf_handler/lib/create_test.dart.expect
- M pkg/vm/testcases/transformations/type_flow/transformer/protobuf_handler/lib/decode_test.dart.expect
- M pkg/vm/testcases/transformations/type_flow/transformer/protobuf_handler/lib/freeze_test.dart.expect
Code-Review: +1 by Alexander Markov
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |