[L] Change in dart/sdk[main]: CQ. Use dedicated scopes in ResolutionVisitor
0 views
Skip to first unread message
Paul Berry (Gerrit)
Feb 13, 2026, 2:50:35 PM (3 days ago) Feb 13
to Konstantin Shcheglov, Johnni Winther, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Johnni Winther and Konstantin Shcheglov
Paul Berry voted and added 1 comment![]( "Open in Gerrit")
Votes added by Paul Berry
| Code-Review | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Paul Berry . resolved
lgtm! This is a really nice design improvement.
Related details
Attention is currently required from:
- Johnni Winther
- Konstantin Shcheglov
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Konstantin Shcheglov (Gerrit)
Feb 14, 2026, 3:03:40 PM (2 days ago) Feb 14
to Paul Berry, Johnni Winther, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Johnni Winther
Konstantin Shcheglov voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Johnni Winther
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Commit Queue (Gerrit)
Feb 14, 2026, 3:25:28 PM (2 days ago) Feb 14
to Konstantin Shcheglov, Paul Berry, Johnni Winther, dart-analys...@google.com, rev...@dartlang.org
Commit Queue submitted the change![]( "Open in Gerrit")
Change information
Commit message:
CQ. Use dedicated scopes in ResolutionVisitor
Replace ad-hoc name-scope setup for generic and executable declarations
with purpose-built scopes that model the language rules more precisely.
- Introduce TypeParameterScope for type parameter lists, backed by a new
helper that binds (or creates) the corresponding fragments in declaration
order without manually injecting them into LocalScope.
- Use FormalParameterScope to make non-initializing formal parameters visible
while resolving function and method bodies, and remove the manual
parameter-definition pass.
- Fix constructor scoping so initializer expressions are resolved under
ConstructorInitializerScope and primary constructor bodies split their work:
initializers run in the initializer scope, while the body runs in
PrimaryParameterScope to preserve correct shadowing and member lookup.
This tightens name resolution around primary constructors and eliminates
redundant LocalScope wrappers where guarded-pattern resolution already
creates the necessary scopes.
Change-Id: Ib84d3524bda4cc0466fc2f927a612b4f20b87cbf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/480721
Reviewed-by: Paul Berry <paul...@google.com>
Commit-Queue: Konstantin Shcheglov <sche...@google.com>
Files:
- M pkg/analyzer/lib/src/dart/resolver/resolution_visitor.dart
- M pkg/analyzer/test/src/dart/resolution/class_test.dart
Change size: L
Delta: 2 files changed, 201 insertions(+), 119 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Paul Berry
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages