[M] Change in dart/sdk[main]: [vm,dyn_modules] Mark extension type members appropriately.
0 views
Skip to first unread message
Tess Strickland (Gerrit)
Nov 26, 2025, 10:46:52 AM (6 days ago) Nov 26
to Alexander Markov, Commit Queue, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Alexander Markov
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Alexander Markov
Submit Requirements:
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tess Strickland (Gerrit)
Nov 26, 2025, 11:24:50 AM (6 days ago) Nov 26
to Alexander Markov, Commit Queue, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Alexander Markov and Tess Strickland
Message from Tess Strickland![]( "Open in Gerrit")
Attention is currently required from:
- Alexander Markov
- Tess Strickland
Submit Requirements:
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alexander Markov (Gerrit)
Dec 1, 2025, 10:11:30 AM (yesterday) Dec 1
to Tess Strickland, Alexander Markov, Commit Queue, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Tess Strickland
Alexander Markov voted and added 2 comments![]( "Open in Gerrit")
Votes added by Alexander Markov
| Code-Review | +1 |
2 comments
File pkg/dart2bytecode/lib/declarations.dart
Line 363, Patchset 5 (Latest):
static const isExtensionTypeMemberFlag = 1 << 17;Alexander Markov . unresolved
Please add the new flag to pkg/dart2bytecode/docs/bytecode.md for `FunctionDeclaration` and `FieldDeclaration`.
File runtime/vm/bytecode_reader.cc
Line 1887, Patchset 5 (Latest):
function.set_is_extension_member(is_extension_member);Alexander Markov . unresolved
Add `function.set_is_extension_type_member(is_extension_type_member)` for the implicit getters too.
Related details
Attention is currently required from:
- Tess Strickland
Submit Requirements:
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tess Strickland (Gerrit)
7:55 AM (3 hours ago) 7:55 AM
to Alexander Markov, Commit Queue, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Alexander Markov
Tess Strickland added 3 comments![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 6 (Latest):
Tess Strickland . resolved
Thanks, Alex! PTAL again, since the bytecode.md change invalidates the +1.
File pkg/dart2bytecode/lib/declarations.dart
Please add the new flag to pkg/dart2bytecode/docs/bytecode.md for `FunctionDeclaration` and `FieldDeclaration`.
Tess Strickland
Done
File runtime/vm/bytecode_reader.cc
Line 1887, Patchset 5:
function.set_is_extension_member(is_extension_member);Alexander Markov . resolved
Add `function.set_is_extension_type_member(is_extension_type_member)` for the implicit getters too.
Attention is currently required from:
- Alexander Markov
Submit Requirements:
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tess Strickland (Gerrit)
8:06 AM (3 hours ago) 8:06 AM
to Alexander Markov, Commit Queue, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Alexander Markov
Tess Strickland voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Related details
Attention is currently required from:
- Alexander Markov
Submit Requirements:
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alexander Markov (Gerrit)
9:30 AM (2 hours ago) 9:30 AM
to Tess Strickland, Alexander Markov, Commit Queue, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Tess Strickland
Alexander Markov voted![]( "Open in Gerrit")
Attention is currently required from:
- Tess Strickland
Submit Requirements:
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Commit Queue (Gerrit)
9:31 AM (2 hours ago) 9:31 AM
to Tess Strickland, Alexander Markov, rev...@dartlang.org, vm-...@dartlang.org
Commit Queue submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[vm,dyn_modules] Mark extension type members appropriately.
TEST=pkg/vm_service/test/step_through_extension_type_method_call_test
Cq-Include-Trybots: luci.dart.try:vm-dyn-linux-debug-x64-try,vm-dyn-mac-debug-arm64-try
Change-Id: I3bf331e175847280964fd42eb027e9f812598bf2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/464705
Auto-Submit: Tess Strickland <sstr...@google.com>
Commit-Queue: Alexander Markov <alexm...@google.com>
Reviewed-by: Alexander Markov <alexm...@google.com>
Files:
- M pkg/dart2bytecode/docs/bytecode.md
- M pkg/dart2bytecode/lib/bytecode_generator.dart
- M pkg/dart2bytecode/lib/declarations.dart
- M runtime/vm/bytecode_reader.cc
Change size: S
Delta: 4 files changed, 26 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Alexander Markov
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages