[XS] Change in dart/sdk[main]: Remove stale TODO comment in `flag_test.dart`.

0 views

Skip to first unread message

Ben Konyi (Gerrit)

unread,

Jul 15, 2026, 1:08:42 PM (12 hours ago) Jul 15

to Jaime Wren, dart-...@luci-project-accounts.iam.gserviceaccount.com, rev...@dartlang.org

Attention needed from Jaime Wren

Ben Konyi voted Code-Review+1

Code-Review

Open in Gerrit

Related details

Attention is currently required from:

Jaime Wren

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Jaime Wren (Gerrit)

unread,

Jul 15, 2026, 2:38:50 PM (11 hours ago) Jul 15

to Ben Konyi, dart-...@luci-project-accounts.iam.gserviceaccount.com, rev...@dartlang.org

Jaime Wren voted Commit-Queue+2

Commit-Queue

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)

unread,

Jul 15, 2026, 2:38:59 PM (10 hours ago) Jul 15

to Jaime Wren, Ben Konyi, rev...@dartlang.org

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change

Change information

Commit message:

Remove stale TODO comment in `flag_test.dart`.

Issue https://github.com/dart-lang/pub/issues/2700 was closed as `NOT_PLANNED` / won't fix. The special-casing for `pub` in `flag_test.dart` remains necessary because `package:pub` intentionally defaults `usageLineLength` to `80` when `stdout.hasTerminal` is false.

Updated the comment to clarify the behavior while maintaining the reference to issue #2700 for context.

Bug: https://github.com/dart-lang/pub/issues/2700

Change-Id: I5b46a302b0ef4134f2caf0f6cb32e0503b8242b1

Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/524230

Commit-Queue: Jaime Wren <jw...@google.com>

Reviewed-by: Ben Konyi <bko...@google.com>

Files:

M pkg/dartdev/test/commands/flag_test.dart

Change size: XS

Delta: 1 file changed, 3 insertions(+), 2 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Ben Konyi

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages